Re: [PATCH 0/7] media: i2c: ov7251: fixes and infrared strobe for Surface Book 2

[Antoine Pichot <antoine.pichot@gmail.com>]

Hi,

On Tue, Oct 27, 2026 at 03:26:42AM -0700, D. Manresa wrote:
> Tested-by: D. Manresa <dmanresa@gmail.com> # Surface Pro 7+, IPU6 (8086:9a19); patches 2-6 only

Thank you for the thorough test. v2 carries the tag on 2, 4 and 5.
Patch 6 changed after Andy's review (the span computation rewritten,
same result), so I will carry it there too unless you object. Patch 3
is replaced by a conversion to the sub-device active state, as Sakari
asked.

> That CID is not added by this series -- it comes from 5be4154f6255
> ("media: v4l: ctrls: add a control for enabling strobe output"), which
> landed after v6.19. Since 6/7 uses v4l2_ctrl_new_std() it needs the
> v4l2-ctrls-defs.c entries too, not just the uapi define, or the control is
> never created. Worth a word in the cover letter for anyone testing on a
> stable tree.

The v2 cover letter will say so: 6/7 needs the strobe control from
kernel 7.0 and is not for stable.

> 4/7: camera_orientation reads Front and camera_sensor_rotation 0, both
> read-only, consistent with the _PLD here.

On the Book 2 the firmware reports 0 but the picture comes out turned by
90 degrees, which 7/7 corrects for that model. Could you please check
whether the frames are upright on the Pro 7+ and, if not, tell me which
way they turn? 7/7 can then carry the Pro 7+ as well.

The link question continues on the 1/7 thread.

Thanks,
Antoine