From: Grygorii Strashko <grygorii.strashko@ti.com>
To: David Miller <davem@davemloft.net>
Cc: <j-keerthy@ti.com>, <linux-omap@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<johan@kernel.org>, <ivan.khoronzhuk@linaro.org>,
<t-kristo@ti.com>, <nsekhar@ti.com>
Subject: Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe
Date: Thu, 20 Jul 2017 17:44:51 -0500 [thread overview]
Message-ID: <0a5cdde6-5898-8f8c-5c56-d47fa9513958@ti.com> (raw)
In-Reply-To: <20170720.152831.802536956243282259.davem@davemloft.net>
On 07/20/2017 05:28 PM, David Miller wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
> Date: Thu, 20 Jul 2017 11:08:09 -0500
>
>> In general patch looks good to me, but it's really unexpected to
>> receive IRQs while CPSW is probing ;(
>
> This is a poor expectation.
>
> Boot loaders and other entities can leave the device in any state
> whatsoever.
>
> Furthermore, enabling an IRQ whose handler cannot properly execute
> without crashing is wrong fundamentally. All data structures and
> state must be set up properly before the IRQ is requested.
>
> Therefore this patch is correct and I will apply it.
>
Thanks. Agree (it just has never triggered before, so I meant - unexpected
from current driver code point of view ;().
And I'm just worry that it might not be enough :(, especially for am335x.
--
regards,
-grygorii
next prev parent reply other threads:[~2017-07-20 22:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 11:29 Keerthy
2017-07-20 16:08 ` Grygorii Strashko
2017-07-20 22:28 ` David Miller
2017-07-20 22:44 ` Grygorii Strashko [this message]
2017-07-21 4:45 ` Keerthy
2017-07-21 15:55 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a5cdde6-5898-8f8c-5c56-d47fa9513958@ti.com \
--to=grygorii.strashko@ti.com \
--cc=davem@davemloft.net \
--cc=ivan.khoronzhuk@linaro.org \
--cc=j-keerthy@ti.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®