Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

[Grygorii Strashko <grygorii.strashko@ti.com>]

On 07/20/2017 11:45 PM, Keerthy wrote:
> 
> 
> On Friday 21 July 2017 04:14 AM, Grygorii Strashko wrote:
>>
>>
>> On 07/20/2017 05:28 PM, David Miller wrote:
>>> From: Grygorii Strashko <grygorii.strashko@ti.com>
>>> Date: Thu, 20 Jul 2017 11:08:09 -0500
>>>
>>>> In general patch looks good to me, but it's really unexpected to
>>>> receive IRQs while CPSW is probing ;(
>>>
>>> This is a poor expectation.
>>>
>>> Boot loaders and other entities can leave the device in any state
>>> whatsoever.
>>>
>>> Furthermore, enabling an IRQ whose handler cannot properly execute
>>> without crashing is wrong fundamentally.  All data structures and
>>> state must be set up properly before the IRQ is requested.
>>>
>>> Therefore this patch is correct and I will apply it.
>>>
>>
>> Thanks. Agree (it just has never triggered before, so I meant - unexpected
>>   from current driver code point of view ;().
>> And I'm just worry that it might not be enough :(, especially for am335x.
> 
> I tried nfs boot on am335x-evm with this patch and it boots fine for me.
> 

Thank you Keerthy, I've also simulated and tested it on am335x and dra7
and see networking working and no crashes.

-- 
regards,
-grygorii