From: Tom Rix <trix@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>,
kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
shivasharan.srikanteshwara@broadcom.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, nathan@kernel.org,
ndesaulniers@google.com
Cc: megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid
Date: Fri, 28 Jan 2022 09:59:54 -0800 [thread overview]
Message-ID: <0adde369-3fd7-3608-594c-d199cce3c936@redhat.com> (raw)
In-Reply-To: <d26d4bd8-b5e1-f4d5-b563-9bc4dd384ff8@acm.org>
On 1/28/22 9:42 AM, Bart Van Assche wrote:
> On 1/27/22 07:19, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> checkpatch reports several hundred formatting errors.
>> Run these files through clang-format and knock off
>> some of them.
>
> Isn't this the kind of patches that carries more risk than value?
> Additionally, this patch conflicts with a patch series that I plan to
> post soon.
>
> Thanks,
I have dropped this patch.
Long term, it would be good have a reliable way to automatically fix
either new files or really broken old files.
So you could do two patches, first would be fixing formatting problems
and second would new stuff.
As it is your new patch will have to both for now.
Tom
>
>
> Bart.
>
next prev parent reply other threads:[~2022-01-28 18:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 15:19 trix
2022-01-27 22:37 ` Finn Thain
2022-01-27 22:47 ` Nick Desaulniers
2022-01-28 0:32 ` Tom Rix
2022-01-28 2:43 ` Joe Perches
2022-01-28 5:31 ` Tom Rix
2022-01-28 8:41 ` Joe Perches
2022-01-28 15:30 ` Tom Rix
2022-01-28 16:23 ` Joe Perches
2022-01-28 23:45 ` Finn Thain
2022-01-28 9:39 ` Miguel Ojeda
2022-01-28 17:42 ` Bart Van Assche
2022-01-28 17:59 ` Tom Rix [this message]
2022-01-28 19:11 ` Joe Perches
2022-01-28 19:37 ` Tom Rix
2022-03-02 19:14 ` Tom Rix
2022-03-03 8:35 ` Finn Thain
2022-03-03 11:41 ` Konrad Wilhelm Kleine
[not found] ` <CABRYuGk+1AGpvfkR7=LTCm+bN4kt55fwQnQXCjidSXWxuMWsiQ@mail.gmail.com>
2022-03-03 22:44 ` Finn Thain
2022-03-03 23:17 ` Miguel Ojeda
2022-03-03 23:38 ` Joe Perches
2022-03-04 5:22 ` Bart Van Assche
2022-03-04 5:40 ` Joe Perches
2022-03-05 3:22 ` Finn Thain
2022-03-04 7:47 ` Finn Thain
2022-03-04 12:31 ` Miguel Ojeda
2022-03-04 13:46 ` Tom Rix
2022-03-04 14:02 ` Miguel Ojeda
2022-03-04 17:36 ` Joe Perches
2022-03-04 18:48 ` Miguel Ojeda
2022-03-04 19:28 ` Joe Perches
2022-03-04 21:04 ` Miguel Ojeda
2022-03-05 3:32 ` Finn Thain
2022-03-04 22:38 ` Tom Rix
2022-01-28 20:30 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0adde369-3fd7-3608-594c-d199cce3c936@redhat.com \
--to=trix@redhat.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®