mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Rix <trix@redhat.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Joe Perches <joe@perches.com>, Finn Thain <fthain@linux-m68k.org>,
	Konrad Wilhelm Kleine <kkleine@redhat.com>,
	Bart Van Assche <bvanassche@acm.org>,
	kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
	shivasharan.srikanteshwara@broadcom.com, jejb@linux.ibm.com,
	martin.petersen@oracle.com, Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	megaraidlinux.pdl@broadcom.com, scsi <linux-scsi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev
Subject: Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid
Date: Fri, 4 Mar 2022 14:38:37 -0800	[thread overview]
Message-ID: <4f535f31-b993-7365-4964-9f7549afc2a1@redhat.com> (raw)
In-Reply-To: <CANiq72nsKijH4zgLoEpiiq4462r1zYmaiDs13SEHDYR3aQziUw@mail.gmail.com>


On 3/4/22 6:02 AM, Miguel Ojeda wrote:
> On Fri, Mar 4, 2022 at 2:46 PM Tom Rix <trix@redhat.com> wrote:
>> The churn level will be very high.
> Nobody is planning to reformat the entire kernel, at least not until
> the tool is close enough to the kernel style, which will take a while.

The churn on a single file like this is high.

There is no way to separate just one type of change, you get all the 
changes.

Not having an opt-in/out per type of change is a flaw that makes 
clang-format not ready.

Tom

>
>> Until clang-format has an opt-in mechanism, I do not think clang-format
>> should be used.
>>
>> .clang-format should be moved to staging/ to reflect its not being ready
>> status.
> What is not ready about it?
>
> It is a fairly useful tool that some people is already using, either
> for full file formatting or for sections within their editor.
>
> Cheers,
> Miguel
>


  parent reply	other threads:[~2022-03-04 22:38 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 15:19 trix
2022-01-27 22:37 ` Finn Thain
2022-01-27 22:47   ` Nick Desaulniers
2022-01-28  0:32     ` Tom Rix
2022-01-28  2:43       ` Joe Perches
2022-01-28  5:31         ` Tom Rix
2022-01-28  8:41           ` Joe Perches
2022-01-28 15:30             ` Tom Rix
2022-01-28 16:23               ` Joe Perches
2022-01-28 23:45               ` Finn Thain
2022-01-28  9:39     ` Miguel Ojeda
2022-01-28 17:42 ` Bart Van Assche
2022-01-28 17:59   ` Tom Rix
2022-01-28 19:11     ` Joe Perches
2022-01-28 19:37       ` Tom Rix
2022-03-02 19:14         ` Tom Rix
2022-03-03  8:35           ` Finn Thain
2022-03-03 11:41             ` Konrad Wilhelm Kleine
     [not found]             ` <CABRYuGk+1AGpvfkR7=LTCm+bN4kt55fwQnQXCjidSXWxuMWsiQ@mail.gmail.com>
2022-03-03 22:44               ` Finn Thain
2022-03-03 23:17                 ` Miguel Ojeda
2022-03-03 23:38                   ` Joe Perches
2022-03-04  5:22                     ` Bart Van Assche
2022-03-04  5:40                       ` Joe Perches
2022-03-05  3:22                       ` Finn Thain
2022-03-04  7:47                     ` Finn Thain
2022-03-04 12:31                     ` Miguel Ojeda
2022-03-04 13:46                     ` Tom Rix
2022-03-04 14:02                       ` Miguel Ojeda
2022-03-04 17:36                         ` Joe Perches
2022-03-04 18:48                           ` Miguel Ojeda
2022-03-04 19:28                             ` Joe Perches
2022-03-04 21:04                               ` Miguel Ojeda
2022-03-05  3:32                               ` Finn Thain
2022-03-04 22:38                         ` Tom Rix [this message]
2022-01-28 20:30       ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f535f31-b993-7365-4964-9f7549afc2a1@redhat.com \
    --to=trix@redhat.com \
    --cc=bvanassche@acm.org \
    --cc=fthain@linux-m68k.org \
    --cc=jejb@linux.ibm.com \
    --cc=joe@perches.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=kkleine@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=martin.petersen@oracle.com \
    --cc=megaraidlinux.pdl@broadcom.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=shivasharan.srikanteshwara@broadcom.com \
    --cc=sumit.saxena@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®