mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Joe Perches <joe@perches.com>, Tom Rix <trix@redhat.com>,
	kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
	shivasharan.srikanteshwara@broadcom.com, jejb@linux.ibm.com,
	martin.petersen@oracle.com, nathan@kernel.org,
	ndesaulniers@google.com
Cc: megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid
Date: Fri, 28 Jan 2022 12:30:13 -0800	[thread overview]
Message-ID: <d570866d-8d2d-3d6b-e0b0-5139e7b990e4@acm.org> (raw)
In-Reply-To: <e3ae392a16491b9ddeb1f0b2b74fdf05628b1996.camel@perches.com>

On 1/28/22 11:11, Joe Perches wrote:
> On Fri, 2022-01-28 at 09:59 -0800, Tom Rix wrote:
>> On 1/28/22 9:42 AM, Bart Van Assche wrote:
>>> Isn't this the kind of patches that carries more risk than value?
> 
> Risk for whitespace style reformatting patches is quite low.

But the annoyance factor for patches that reformat an entire source file 
is very high. It forces everyone who has conflicting patches pending to 
wait until the reformatting patch went in, rebase their tree and also to 
resolve the complicated merge conflicts that are the result of the 
reformatting patch. I have already had to do this several times in the past.

Thanks,

Bart.

      parent reply	other threads:[~2022-01-28 20:30 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 15:19 trix
2022-01-27 22:37 ` Finn Thain
2022-01-27 22:47   ` Nick Desaulniers
2022-01-28  0:32     ` Tom Rix
2022-01-28  2:43       ` Joe Perches
2022-01-28  5:31         ` Tom Rix
2022-01-28  8:41           ` Joe Perches
2022-01-28 15:30             ` Tom Rix
2022-01-28 16:23               ` Joe Perches
2022-01-28 23:45               ` Finn Thain
2022-01-28  9:39     ` Miguel Ojeda
2022-01-28 17:42 ` Bart Van Assche
2022-01-28 17:59   ` Tom Rix
2022-01-28 19:11     ` Joe Perches
2022-01-28 19:37       ` Tom Rix
2022-03-02 19:14         ` Tom Rix
2022-03-03  8:35           ` Finn Thain
2022-03-03 11:41             ` Konrad Wilhelm Kleine
     [not found]             ` <CABRYuGk+1AGpvfkR7=LTCm+bN4kt55fwQnQXCjidSXWxuMWsiQ@mail.gmail.com>
2022-03-03 22:44               ` Finn Thain
2022-03-03 23:17                 ` Miguel Ojeda
2022-03-03 23:38                   ` Joe Perches
2022-03-04  5:22                     ` Bart Van Assche
2022-03-04  5:40                       ` Joe Perches
2022-03-05  3:22                       ` Finn Thain
2022-03-04  7:47                     ` Finn Thain
2022-03-04 12:31                     ` Miguel Ojeda
2022-03-04 13:46                     ` Tom Rix
2022-03-04 14:02                       ` Miguel Ojeda
2022-03-04 17:36                         ` Joe Perches
2022-03-04 18:48                           ` Miguel Ojeda
2022-03-04 19:28                             ` Joe Perches
2022-03-04 21:04                               ` Miguel Ojeda
2022-03-05  3:32                               ` Finn Thain
2022-03-04 22:38                         ` Tom Rix
2022-01-28 20:30       ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d570866d-8d2d-3d6b-e0b0-5139e7b990e4@acm.org \
    --to=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=joe@perches.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=martin.petersen@oracle.com \
    --cc=megaraidlinux.pdl@broadcom.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=shivasharan.srikanteshwara@broadcom.com \
    --cc=sumit.saxena@broadcom.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®