From: Andrew Lunn <andrew@lunn.ch>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
Frank.Sae@motor-comm.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, shenjian15@huawei.com,
liuyonglong@huawei.com, chenhao418@huawei.com,
jonathan.cameron@huawei.com, salil.mehta@huawei.com,
shiyongbang@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC net-next 6/6] net: phy: motorcomm: fix duplex setting error for phy leds
Date: Wed, 17 Dec 2025 14:49:45 +0100 [thread overview]
Message-ID: <0bb9d5a1-e01c-4d7d-b668-3bf81e98447b@lunn.ch> (raw)
In-Reply-To: <143514a2-e538-47e2-920c-f223667cb900@huawei.com>
On Wed, Dec 17, 2025 at 09:05:20PM +0800, Jijie Shao wrote:
>
> on 2025/12/16 15:21, Andrew Lunn wrote:
> > On Mon, Dec 15, 2025 at 08:57:05PM +0800, Jijie Shao wrote:
> > > fix duplex setting error for phy leds
> > >
> > > Fixes: 355b82c54c12 ("net: phy: motorcomm: Add support for PHY LEDs on YT8521")
> > > Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> > Please don't mix new development and fixes in one patchset. Please
> > base this patch on net, and send it on its own.
> >
> > https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
> >
> > Fixes are accepted any time, it does not matter about the merge
> > window.
> >
> > Andrew
>
> Yes, this is RFC, just for code review.
> I sent it to net when requesting a merge.
This is however a real fix. The motorcomm driver is broken. Why wait
to fix it?
Andrew
next prev parent reply other threads:[~2025-12-17 13:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 12:56 [PATCH RFC net-next 0/6] Support PHY LED for hibmcge driver Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 1/6] net: phy: change of_phy_leds() to fwnode_phy_leds() Jijie Shao
2025-12-17 10:37 ` Jonathan Cameron
2025-12-17 13:18 ` Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 2/6] net: phy: add support to set default rules Jijie Shao
2025-12-16 7:09 ` Andrew Lunn
2025-12-17 12:54 ` Jijie Shao
2025-12-17 13:53 ` Andrew Lunn
2025-12-18 1:35 ` Jijie Shao
2025-12-18 10:12 ` Andrew Lunn
2026-01-07 9:40 ` Jijie Shao
2026-01-07 13:09 ` Andrew Lunn
2026-01-08 7:00 ` Jijie Shao
2026-01-08 14:31 ` Andrew Lunn
2026-01-02 11:26 ` Russell King (Oracle)
2026-01-07 9:43 ` Jijie Shao
2026-01-07 9:50 ` Russell King (Oracle)
2026-01-07 10:12 ` Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 3/6] net: hibmcge: create a software node for phy_led Jijie Shao
2025-12-16 7:17 ` Andrew Lunn
2025-12-17 12:57 ` Jijie Shao
2026-01-07 10:09 ` Jijie Shao
2026-01-07 13:04 ` Andrew Lunn
2026-01-08 6:57 ` Jijie Shao
2026-01-08 13:59 ` Andrew Lunn
2025-12-15 12:57 ` [PATCH RFC net-next 4/6] net: hibmcge: support get phy_leds_reg from spec register Jijie Shao
2025-12-16 7:19 ` Andrew Lunn
2025-12-17 13:02 ` Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 5/6] net: hibmcge: support get phy device from apci Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 6/6] net: phy: motorcomm: fix duplex setting error for phy leds Jijie Shao
2025-12-16 7:21 ` Andrew Lunn
2025-12-17 13:05 ` Jijie Shao
2025-12-17 13:49 ` Andrew Lunn [this message]
2025-12-18 1:39 ` Jijie Shao
2025-12-15 14:46 ` [PATCH RFC net-next 0/6] Support PHY LED for hibmcge driver Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bb9d5a1-e01c-4d7d-b668-3bf81e98447b@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®