mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
	Frank.Sae@motor-comm.com, hkallweit1@gmail.com,
	linux@armlinux.org.uk, shenjian15@huawei.com,
	liuyonglong@huawei.com, chenhao418@huawei.com,
	jonathan.cameron@huawei.com, salil.mehta@huawei.com,
	shiyongbang@huawei.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC net-next 2/6] net: phy: add support to set default rules
Date: Tue, 16 Dec 2025 08:09:29 +0100	[thread overview]
Message-ID: <fe22ae64-2a09-45ce-8dbf-a4683745e21c@lunn.ch> (raw)
In-Reply-To: <20251215125705.1567527-3-shaojijie@huawei.com>

On Mon, Dec 15, 2025 at 08:57:01PM +0800, Jijie Shao wrote:
> The node of led need add new property: rules,
> and rules can be set as:
> BIT(TRIGGER_NETDEV_LINK) | BIT(TRIGGER_NETDEV_RX)

Please could you expand this description. It is not clear to my why it
is needed. OF systems have not needed it so far. What is special about
your hardware?

Also, it looks like you are expanding the DT binding, so you need to
update the binding .yaml file.

	Andrew

  reply	other threads:[~2025-12-16  7:09 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15 12:56 [PATCH RFC net-next 0/6] Support PHY LED for hibmcge driver Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 1/6] net: phy: change of_phy_leds() to fwnode_phy_leds() Jijie Shao
2025-12-17 10:37   ` Jonathan Cameron
2025-12-17 13:18     ` Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 2/6] net: phy: add support to set default rules Jijie Shao
2025-12-16  7:09   ` Andrew Lunn [this message]
2025-12-17 12:54     ` Jijie Shao
2025-12-17 13:53       ` Andrew Lunn
2025-12-18  1:35         ` Jijie Shao
2025-12-18 10:12           ` Andrew Lunn
2026-01-07  9:40             ` Jijie Shao
2026-01-07 13:09           ` Andrew Lunn
2026-01-08  7:00             ` Jijie Shao
2026-01-08 14:31               ` Andrew Lunn
2026-01-02 11:26       ` Russell King (Oracle)
2026-01-07  9:43         ` Jijie Shao
2026-01-07  9:50           ` Russell King (Oracle)
2026-01-07 10:12             ` Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 3/6] net: hibmcge: create a software node for phy_led Jijie Shao
2025-12-16  7:17   ` Andrew Lunn
2025-12-17 12:57     ` Jijie Shao
2026-01-07 10:09     ` Jijie Shao
2026-01-07 13:04       ` Andrew Lunn
2026-01-08  6:57         ` Jijie Shao
2026-01-08 13:59           ` Andrew Lunn
2025-12-15 12:57 ` [PATCH RFC net-next 4/6] net: hibmcge: support get phy_leds_reg from spec register Jijie Shao
2025-12-16  7:19   ` Andrew Lunn
2025-12-17 13:02     ` Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 5/6] net: hibmcge: support get phy device from apci Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 6/6] net: phy: motorcomm: fix duplex setting error for phy leds Jijie Shao
2025-12-16  7:21   ` Andrew Lunn
2025-12-17 13:05     ` Jijie Shao
2025-12-17 13:49       ` Andrew Lunn
2025-12-18  1:39         ` Jijie Shao
2025-12-15 14:46 ` [PATCH RFC net-next 0/6] Support PHY LED for hibmcge driver Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe22ae64-2a09-45ce-8dbf-a4683745e21c@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Frank.Sae@motor-comm.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=chenhao418@huawei.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=jonathan.cameron@huawei.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=liuyonglong@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=salil.mehta@huawei.com \
    --cc=shaojijie@huawei.com \
    --cc=shenjian15@huawei.com \
    --cc=shiyongbang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®