Re: [PATCH RFC net-next 3/6] net: hibmcge: create a software node for phy_led

[Jijie Shao <shaojijie@huawei.com>]

on 2026/1/7 21:04, Andrew Lunn wrote:
> On Wed, Jan 07, 2026 at 06:09:28PM +0800, Jijie Shao wrote:
>> on 2025/12/16 15:17, Andrew Lunn wrote:
>>> On Mon, Dec 15, 2025 at 08:57:02PM +0800, Jijie Shao wrote:
>>>
>>>> +int hbg_mdio_init(struct hbg_priv *priv)
>>>> +{
>>>> +	struct device *dev = &priv->pdev->dev;
>>>> +	struct hbg_mac *mac = &priv->mac;
>>>>    	struct mii_bus *mdio_bus;
>>>>    	int ret;
>>>> @@ -281,7 +389,7 @@ int hbg_mdio_init(struct hbg_priv *priv)
>>>>    	mdio_bus->parent = dev;
>>>>    	mdio_bus->priv = priv;
>>>> -	mdio_bus->phy_mask = ~(1 << mac->phy_addr);
>>>> +	mdio_bus->phy_mask = 0xFFFFFFFF; /* not scan phy device */
>>>>    	mdio_bus->name = "hibmcge mii bus";
>>>>    	mac->mdio_bus = mdio_bus;
>>> I think you are taking the wrong approach.
>>>
>>> Please consider trying to use of_mdiobus_register(). Either load a DT
>>> overlay, or see if you can construct a tree of properties as you have
>>> been doing, and pass it to of_mdiobus_register(). You then don't need
>>> to destroy and create PHY devices.
>> This is not easy.
>> `of_mdiobus_register()` requires a device_node, but I currently don't have one.
>> It is precisely because there is no DT or ACPI node that I am using a software node as a substitute.
> Which is why i suggested DT overlay.
>
> drivers/misc/lan966x_pci.dtso
>
> 	Andrew

Thank you for the guidance.

I did some research, and it seems that our board uses ACPI,
so it might not be possible to use this method.

If we rely on ACPI, we would need to ask the BIOS team to add ACPI entries.
I need to communicate with the customer's BIOS team, which may not be easy.

Personally, I think that using software node is more efficient when OF cannot be used.

Note: Patches with questions will continue to be discussed.
I will sent the patches that currently have no issues to net-next for acceptance.

Thanks,
Jijie Shao