mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chang S. Bae" <chang.seok.bae@intel.com>
To: Andrei Vagin <avagin@gmail.com>
Cc: Andrei Vagin <avagin@google.com>,
	Thomas Gleixner <tglx@kernel.org>,
	"Ingo Molnar" <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	<linux-kernel@vger.kernel.org>, <criu@lists.linux.dev>,
	Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 09/10] x86/fpu: Allow restoring signal frames with larger xstate_size
Date: Fri, 7 Aug 2026 08:56:38 -0700	[thread overview]
Message-ID: <0be62adf-a225-4c35-b526-6b216355797d@intel.com> (raw)
In-Reply-To: <CANaxB-yGA+vy5TiKqAOfN82EeXEcgMWrKrYGx-A6Tw-hJ_GEpg@mail.gmail.com>

On 8/4/2026 1:30 PM, Andrei Vagin wrote:
> 
> We can do something like this in check_xstate_in_sigframe():
> unenabled = fx_sw->xfeatures & ~fpstate->user_xfeatures;
> unenabled &= xstate_get_host_group_perm() & XFEATURE_MASK_USER_DYNAMIC;
> if (unenabled) {
>          if (xfd_enable_feature(unenabled))
>                  return false;
>          fpstate = x86_task_fpu(current)->fpstate;
> }
The inner function __xfd_enable_feature() is currently invoked from two 
spots: (1) the #NM handler on the first userspace touch of a dynamic 
state, and (2) VCPU allocation when creating an AMX-enabled VM.

For the latter, this was a chosen approach for the simplest AFAIK. Along 
with the same lines, the ptracer path deliberately does _not_ expand a 
ptracee's dynamic state.

I would expect ptrace to be the first place to adopt such an expanding 
context injection. I'm not suggesting it at all; rather, the fact that 
ptrace does not do such suggests there has been a conscious effort to 
avoid adding complexity around XFD/dynamic-state management.

Given that, it looks less convincing without first demonstrating that 
this cannot be handled in userspace. More importantly, since this would 
introduce yet another way for expanding the XSAVE buffer, it deserves 
auditing possible side-effects.

Thanks,
Chang

  reply	other threads:[~2026-08-07 15:56 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15 19:37 [PATCH v3 0/10] x86/fpu: Restore and reinforce signal frame portability Andrei Vagin
2026-06-15 19:37 ` [PATCH 01/10] x86/fpu: Document " Andrei Vagin
2026-06-26 13:51   ` Alexander Mikhalitsyn
2026-06-30 19:23   ` Chang S. Bae
2026-06-15 19:37 ` [PATCH 02/10] x86/fpu: Clean up and rename variables in signal frame handling Andrei Vagin
2026-06-26 17:05   ` Alexander Mikhalitsyn
2026-06-15 19:37 ` [PATCH 03/10] x86/fpu: Split __fpu_restore_sig to extract compat path Andrei Vagin
2026-06-26 17:20   ` Alexander Mikhalitsyn
2026-06-15 19:37 ` [PATCH 04/10] x86/fpu: Document reasoning of FX-only fallback Andrei Vagin
2026-06-26 14:22   ` Alexander Mikhalitsyn
2026-06-30 19:23   ` Chang S. Bae
2026-07-31 15:34     ` Andrei Vagin
2026-06-15 19:37 ` [PATCH 05/10] x86/fpu: Fix potential underflow in xstate_calculate_size() Andrei Vagin
2026-06-26 14:32   ` Alexander Mikhalitsyn
2026-06-30 19:23   ` Chang S. Bae
2026-06-15 19:37 ` [PATCH 06/10] selftests/x86: Add a test for signal frame FPU portability Andrei Vagin
2026-06-26 14:39   ` Alexander Mikhalitsyn
2026-06-15 19:37 ` [PATCH 07/10] x86/fpu: Pre-fault only required size of xstate buffer Andrei Vagin
2026-06-26 17:28   ` Alexander Mikhalitsyn
2026-06-15 19:37 ` [PATCH 08/10] selftests/x86: Add a sigframe insufficient xstate_size test Andrei Vagin
2026-06-26 15:02   ` Alexander Mikhalitsyn
2026-06-15 19:37 ` [PATCH 09/10] x86/fpu: Allow restoring signal frames with larger xstate_size Andrei Vagin
2026-06-26 17:32   ` Alexander Mikhalitsyn
2026-06-30 19:23   ` Chang S. Bae
2026-07-01  0:48     ` Andrei Vagin
2026-07-06 17:08       ` Chang S. Bae
2026-07-07 20:27         ` Andrei Vagin
2026-07-09 21:14           ` Chang S. Bae
2026-07-10 22:24             ` Chang S. Bae
2026-07-22  0:35             ` Andrei Vagin
2026-07-30 21:26               ` Andrei Vagin
2026-08-01  0:49                 ` Chang S. Bae
2026-08-04 20:30                   ` Andrei Vagin
2026-08-07 15:56                     ` Chang S. Bae [this message]
2026-08-07 23:12                       ` Andrei Vagin
2026-08-08  3:05                         ` Chang S. Bae
2026-08-08 18:50                           ` Andrei Vagin
2026-08-11  6:06                             ` Chang S. Bae
2026-08-14 21:00                               ` Andrei Vagin
2026-08-17 14:23                                 ` Chang S. Bae
2026-08-17 16:36                                   ` Andrei Vagin
2026-06-15 19:37 ` [PATCH 10/10] selftests/x86: Check restoring FPU state " Andrei Vagin
2026-06-26 15:12   ` Alexander Mikhalitsyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0be62adf-a225-4c35-b526-6b216355797d@intel.com \
    --to=chang.seok.bae@intel.com \
    --cc=avagin@gmail.com \
    --cc=avagin@google.com \
    --cc=bp@alien8.de \
    --cc=criu@lists.linux.dev \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®