* [PATCH] staging: rtl8723bs: declare private function as static
@ 2017-04-23 17:37 Kenneth Hsu
2017-04-30 19:07 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Kenneth Hsu @ 2017-04-23 17:37 UTC (permalink / raw)
To: gregkh, hdegoede, linux-kernel
This fixes a sparse warning regarding an undeclared symbol. Since the
function is private to rtw_recv.c, it should be declared as static.
Signed-off-by: Kenneth Hsu <kennethhsu@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 74e11948c015..695a5c958c80 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1717,7 +1717,8 @@ sint wlanhdr_to_ethhdr(union recv_frame *precvframe)
}
/* perform defrag */
-union recv_frame *recvframe_defrag(struct adapter *adapter, struct __queue *defrag_q)
+static union recv_frame *recvframe_defrag(struct adapter *adapter,
+ struct __queue *defrag_q)
{
struct list_head *plist, *phead;
u8 *data, wlanhdr_offset;
--
2.12.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: declare private function as static
2017-04-23 17:37 [PATCH] staging: rtl8723bs: declare private function as static Kenneth Hsu
@ 2017-04-30 19:07 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2017-04-30 19:07 UTC (permalink / raw)
To: Kenneth Hsu, gregkh, linux-kernel
Hi,
On 23-04-17 19:37, Kenneth Hsu wrote:
> This fixes a sparse warning regarding an undeclared symbol. Since the
> function is private to rtw_recv.c, it should be declared as static.
>
> Signed-off-by: Kenneth Hsu <kennethhsu@gmail.com>
Looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 74e11948c015..695a5c958c80 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1717,7 +1717,8 @@ sint wlanhdr_to_ethhdr(union recv_frame *precvframe)
> }
>
> /* perform defrag */
> -union recv_frame *recvframe_defrag(struct adapter *adapter, struct __queue *defrag_q)
> +static union recv_frame *recvframe_defrag(struct adapter *adapter,
> + struct __queue *defrag_q)
> {
> struct list_head *plist, *phead;
> u8 *data, wlanhdr_offset;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-30 19:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-23 17:37 [PATCH] staging: rtl8723bs: declare private function as static Kenneth Hsu
2017-04-30 19:07 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®