mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Heming Zhao <heming.zhao@suse.com>,
	ZhengYuan Huang <gality369@gmail.com>,
	ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] ocfs2: consolidate extent list validation into block read callbacks
Date: Tue, 7 Apr 2026 09:44:38 +0800	[thread overview]
Message-ID: <0c733707-d339-42f4-a11b-b597487918dc@linux.alibaba.com> (raw)
In-Reply-To: <20260403122714.d01b268f8ac8148aaf55dc3c@linux-foundation.org>



On 4/4/26 3:27 AM, Andrew Morton wrote:
> On Fri,  3 Apr 2026 17:07:59 +0800 Joseph Qi <joseph.qi@linux.alibaba.com> wrote:
> 
>> ocfs2 validates extent list fields (l_count, l_next_free_rec) at various
>> points during extent tree traversal. This is fragile because each caller
>> must remember to check for corrupted on-disk data before using it.
>>
>> This series moves those checks into the block read validation callbacks
>> (ocfs2_validate_dx_root and ocfs2_validate_extent_block), so corrupted
>> fields are caught early at block read time. Redundant post-read checks
>> are then removed.
> 
> AI review asked a few questions - mainly suggesting additional changes.
> https://sashiko.dev/#/patchset/20260403090803.3860971-1-joseph.qi@linux.alibaba.com

Yes, not regressions, actually some improvements.

Thanks,
Joseph



      reply	other threads:[~2026-04-07  1:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-03  9:07 Joseph Qi
2026-04-03  9:08 ` [PATCH 1/4] ocfs2: validate dx_root extent list fields during block read Joseph Qi
2026-04-07 14:58   ` Heming Zhao
2026-04-03  9:08 ` [PATCH 2/4] ocfs2: remove empty extent list check in ocfs2_dx_dir_lookup_rec() Joseph Qi
2026-04-07 14:59   ` Heming Zhao
2026-04-03  9:08 ` [PATCH 3/4] ocfs2: validate extent block list fields during block read Joseph Qi
2026-04-07 15:00   ` Heming Zhao
2026-04-03  9:08 ` [PATCH 4/4] ocfs2: remove redundant l_next_free_rec check in __ocfs2_find_path() Joseph Qi
2026-04-07 15:01   ` Heming Zhao
2026-04-03 19:27 ` [PATCH 0/4] ocfs2: consolidate extent list validation into block read callbacks Andrew Morton
2026-04-07  1:44   ` Joseph Qi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c733707-d339-42f4-a11b-b597487918dc@linux.alibaba.com \
    --to=joseph.qi@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=gality369@gmail.com \
    --cc=heming.zhao@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ocfs2-devel@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®