From: "Timur Kristóf" <timur.kristof@gmail.com>
To: "Christian König" <christian.koenig@amd.com>,
"Matheus Tagliari" <mptagliari@gmail.com>,
"Alex Deucher" <alexander.deucher@amd.com>
Cc: David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] drm/radeon: process the VCE interrupt on SI and Trinity
Date: Mon, 26 Oct 2026 23:41:07 +0100 [thread overview]
Message-ID: <0c7e45a13fb78064390818bb501e754b62f16f6e.camel@gmail.com> (raw)
In-Reply-To: <88c61950-125e-4109-955e-ce09ebaab7af@amd.com>
On Mon, 2026-10-26 at 09:22 +0100, Christian König wrote:
> On 10/22/26 13:47, Matheus Tagliari wrote:
> > radeon_vce_fence_emit() ends every VCE fence with VCE_CMD_TRAP,
> > which
> > raises the VCE trap interrupt (IH src_id 167). cik_irq_process()
> > handles it by calling radeon_fence_process() for the matching VCE
> > ring,
> > but si_irq_process() and evergreen_irq_process(), which serve the
> > other
> > ASICs with VCE1 (SI and Trinity/Richland), have no case for it.
> >
> > Add the same handling. The trap interrupt is not enabled on these
> > ASICs yet, so this does not change behaviour on its own; the next
> > patch
> > enables it.
> >
> > The SI part was tested together with the next patch. The Trinity
> > part
> > mirrors the CIK and SI code and has not been tested on
> > Trinity/Richland
> > hardware.
> >
> > Fixes: a918efab631a ("drm/radeon: add VCE 1.0 support v4")
> > Cc: stable@vger.kernel.org
>
> Please drop that, we really don't want this to be backported.
Hi Christian & Matheus,
Why wouldn't want this patch to be backported?
AFAIU the main case for this patch set is to fix VCE1 for people who
are still stuck on the old radeon KMD on old distros that ship an LTS
kernel version.
Timur
next prev parent reply other threads:[~2026-10-26 22:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 11:47 [PATCH v2 0/2] drm/radeon: fix VCE1 encoding on SI by handling the VCE interrupt Matheus Tagliari
2026-10-22 11:47 ` [PATCH v2 1/2] drm/radeon: process the VCE interrupt on SI and Trinity Matheus Tagliari
2026-10-26 8:22 ` Christian König
2026-10-26 13:02 ` Matheus Tagliari
2026-10-26 22:41 ` Timur Kristóf [this message]
2026-10-27 0:15 ` Matheus Tagliari
2026-10-22 11:47 ` [PATCH v2 2/2] drm/radeon/vce1: enable the VCE trap interrupt Matheus Tagliari
2026-10-22 15:12 ` [PATCH v2 0/2] drm/radeon: fix VCE1 encoding on SI by handling the VCE interrupt Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c7e45a13fb78064390818bb501e754b62f16f6e.camel@gmail.com \
--to=timur.kristof@gmail.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mptagliari@gmail.com \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®