[PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

[PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

[sunran001]

Fix four occurrences of the checkpatch.pl error:
ERROR: "(foo*)" should be "(foo *)"

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  drivers/gpu/drm/radeon/radeon_atombios.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c 
b/drivers/gpu/drm/radeon/radeon_atombios.c
index bf3c411a55c5..85c4bb186203 100644
--- a/drivers/gpu/drm/radeon/radeon_atombios.c
+++ b/drivers/gpu/drm/radeon/radeon_atombios.c
@@ -1389,7 +1389,7 @@ bool radeon_atombios_get_ppll_ss_info(struct 
radeon_device *rdev,

          num_indices = (size - sizeof(ATOM_COMMON_TABLE_HEADER)) /
              sizeof(ATOM_SPREAD_SPECTRUM_ASSIGNMENT);
-        ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT*)
+        ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT *)
              ((u8 *)&ss_info->asSS_Info[0]);
          for (i = 0; i < num_indices; i++) {
              if (ss_assign->ucSS_Id == id) {
@@ -1402,7 +1402,7 @@ bool radeon_atombios_get_ppll_ss_info(struct 
radeon_device *rdev,
                  ss->refdiv = ss_assign->ucRecommendedRef_Div;
                  return true;
              }
-            ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT*)
+            ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT *)
                  ((u8 *)ss_assign + sizeof(struct 
_ATOM_SPREAD_SPECTRUM_ASSIGNMENT));
          }
      }
@@ -3406,7 +3406,7 @@ static ATOM_VOLTAGE_OBJECT_V2 
*atom_lookup_voltage_object_v2(ATOM_VOLTAGE_OBJECT
  {
      u32 size = le16_to_cpu(v2->sHeader.usStructureSize);
      u32 offset = offsetof(ATOM_VOLTAGE_OBJECT_INFO_V2, 
asVoltageObj[0]);
-    u8 *start = (u8*)v2;
+    u8 *start = (u8 *)v2;

      while (offset < size) {
          ATOM_VOLTAGE_OBJECT_V2 *vo = (ATOM_VOLTAGE_OBJECT_V2 *)(start + 
offset);
@@ -3423,7 +3423,7 @@ static ATOM_VOLTAGE_OBJECT_V3 
*atom_lookup_voltage_object_v3(ATOM_VOLTAGE_OBJECT
  {
      u32 size = le16_to_cpu(v3->sHeader.usStructureSize);
      u32 offset = offsetof(ATOM_VOLTAGE_OBJECT_INFO_V3_1, 
asVoltageObj[0]);
-    u8 *start = (u8*)v3;
+    u8 *start = (u8 *)v3;

      while (offset < size) {
          ATOM_VOLTAGE_OBJECT_V3 *vo = (ATOM_VOLTAGE_OBJECT_V3 *)(start + 
offset);

Re: [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

[Alex Deucher]

Applied.  Thanks!

On Mon, Jul 10, 2023 at 4:27 AM <sunran001@208suo.com> wrote:
>
> Fix four occurrences of the checkpatch.pl error:
> ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   drivers/gpu/drm/radeon/radeon_atombios.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c
> b/drivers/gpu/drm/radeon/radeon_atombios.c
> index bf3c411a55c5..85c4bb186203 100644
> --- a/drivers/gpu/drm/radeon/radeon_atombios.c
> +++ b/drivers/gpu/drm/radeon/radeon_atombios.c
> @@ -1389,7 +1389,7 @@ bool radeon_atombios_get_ppll_ss_info(struct
> radeon_device *rdev,
>
>           num_indices = (size - sizeof(ATOM_COMMON_TABLE_HEADER)) /
>               sizeof(ATOM_SPREAD_SPECTRUM_ASSIGNMENT);
> -        ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT*)
> +        ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT *)
>               ((u8 *)&ss_info->asSS_Info[0]);
>           for (i = 0; i < num_indices; i++) {
>               if (ss_assign->ucSS_Id == id) {
> @@ -1402,7 +1402,7 @@ bool radeon_atombios_get_ppll_ss_info(struct
> radeon_device *rdev,
>                   ss->refdiv = ss_assign->ucRecommendedRef_Div;
>                   return true;
>               }
> -            ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT*)
> +            ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT *)
>                   ((u8 *)ss_assign + sizeof(struct
> _ATOM_SPREAD_SPECTRUM_ASSIGNMENT));
>           }
>       }
> @@ -3406,7 +3406,7 @@ static ATOM_VOLTAGE_OBJECT_V2
> *atom_lookup_voltage_object_v2(ATOM_VOLTAGE_OBJECT
>   {
>       u32 size = le16_to_cpu(v2->sHeader.usStructureSize);
>       u32 offset = offsetof(ATOM_VOLTAGE_OBJECT_INFO_V2,
> asVoltageObj[0]);
> -    u8 *start = (u8*)v2;
> +    u8 *start = (u8 *)v2;
>
>       while (offset < size) {
>           ATOM_VOLTAGE_OBJECT_V2 *vo = (ATOM_VOLTAGE_OBJECT_V2 *)(start +
> offset);
> @@ -3423,7 +3423,7 @@ static ATOM_VOLTAGE_OBJECT_V3
> *atom_lookup_voltage_object_v3(ATOM_VOLTAGE_OBJECT
>   {
>       u32 size = le16_to_cpu(v3->sHeader.usStructureSize);
>       u32 offset = offsetof(ATOM_VOLTAGE_OBJECT_INFO_V3_1,
> asVoltageObj[0]);
> -    u8 *start = (u8*)v3;
> +    u8 *start = (u8 *)v3;
>
>       while (offset < size) {
>           ATOM_VOLTAGE_OBJECT_V3 *vo = (ATOM_VOLTAGE_OBJECT_V3 *)(start +
> offset);

[PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

[shijie001]

Fix one occurrence of the checkpatch.pl error:
ERROR: "(foo*)" should be "(foo *)"

Signed-off-by: Jie Shi <shijie001@208suo.com>
---
  drivers/gpu/drm/radeon/uvd_v1_0.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/uvd_v1_0.c 
b/drivers/gpu/drm/radeon/uvd_v1_0.c
index 58557c2263a7..5684639d20a6 100644
--- a/drivers/gpu/drm/radeon/uvd_v1_0.c
+++ b/drivers/gpu/drm/radeon/uvd_v1_0.c
@@ -142,7 +142,7 @@ int uvd_v1_0_resume(struct radeon_device *rdev)
      addr = (rdev->uvd.gpu_addr >> 32) & 0xFF;
      WREG32(UVD_LMI_EXT40_ADDR, addr | (0x9 << 16) | (0x1 << 31));

-    WREG32(UVD_FW_START, *((uint32_t*)rdev->uvd.cpu_addr));
+    WREG32(UVD_FW_START, *((uint32_t *)rdev->uvd.cpu_addr));

      return 0;
  }

Re: [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

[Christian König]

Am 14.07.23 um 07:35 schrieb shijie001@208suo.com:
> Fix one occurrence of the checkpatch.pl error:
> ERROR: "(foo*)" should be "(foo *)"

It's nice to see all those little typos fixed, but I'm not sure how 
feasible it is to send patches for each type individually.

Maybe just merge them together into one patch for the whole radeon code 
base.

Additional to that I'm pretty sure that most of that stuff is already 
fixed, so what base do you use for this?

Regards,
Christian.

>
> Signed-off-by: Jie Shi <shijie001@208suo.com>
> ---
>  drivers/gpu/drm/radeon/uvd_v1_0.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/uvd_v1_0.c 
> b/drivers/gpu/drm/radeon/uvd_v1_0.c
> index 58557c2263a7..5684639d20a6 100644
> --- a/drivers/gpu/drm/radeon/uvd_v1_0.c
> +++ b/drivers/gpu/drm/radeon/uvd_v1_0.c
> @@ -142,7 +142,7 @@ int uvd_v1_0_resume(struct radeon_device *rdev)
>      addr = (rdev->uvd.gpu_addr >> 32) & 0xFF;
>      WREG32(UVD_LMI_EXT40_ADDR, addr | (0x9 << 16) | (0x1 << 31));
>
> -    WREG32(UVD_FW_START, *((uint32_t*)rdev->uvd.cpu_addr));
> +    WREG32(UVD_FW_START, *((uint32_t *)rdev->uvd.cpu_addr));
>
>      return 0;
>  }

[PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

[sunran001]

Fix five occurrences of the checkpatch.pl error:
ERROR: "(foo*)" should be "(foo *)"

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  drivers/gpu/drm/radeon/radeon_kms.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_kms.c 
b/drivers/gpu/drm/radeon/radeon_kms.c
index e0214cf1b43b..a16590c6247f 100644
--- a/drivers/gpu/drm/radeon/radeon_kms.c
+++ b/drivers/gpu/drm/radeon/radeon_kms.c
@@ -444,7 +444,7 @@ int radeon_info_ioctl(struct drm_device *dev, void 
*data, struct drm_file *filp)
              DRM_DEBUG_KMS("timestamp is r6xx+ only!\n");
              return -EINVAL;
          }
-        value = (uint32_t*)&value64;
+        value = (uint32_t *)&value64;
          value_size = sizeof(uint64_t);
          value64 = radeon_get_gpu_clock_counter(rdev);
          break;
@@ -543,18 +543,18 @@ int radeon_info_ioctl(struct drm_device *dev, void 
*data, struct drm_file *filp)
          *value = rdev->vce.fb_version;
          break;
      case RADEON_INFO_NUM_BYTES_MOVED:
-        value = (uint32_t*)&value64;
+        value = (uint32_t *)&value64;
          value_size = sizeof(uint64_t);
          value64 = atomic64_read(&rdev->num_bytes_moved);
          break;
      case RADEON_INFO_VRAM_USAGE:
-        value = (uint32_t*)&value64;
+        value = (uint32_t *)&value64;
          value_size = sizeof(uint64_t);
          man = ttm_manager_type(&rdev->mman.bdev, TTM_PL_VRAM);
          value64 = ttm_resource_manager_usage(man);
          break;
      case RADEON_INFO_GTT_USAGE:
-        value = (uint32_t*)&value64;
+        value = (uint32_t *)&value64;
          value_size = sizeof(uint64_t);
          man = ttm_manager_type(&rdev->mman.bdev, TTM_PL_TT);
          value64 = ttm_resource_manager_usage(man);
@@ -614,7 +614,7 @@ int radeon_info_ioctl(struct drm_device *dev, void 
*data, struct drm_file *filp)
          DRM_DEBUG_KMS("Invalid request %d\n", info->request);
          return -EINVAL;
      }
-    if (copy_to_user(value_ptr, (char*)value, value_size)) {
+    if (copy_to_user(value_ptr, (char *)value, value_size)) {
          DRM_ERROR("copy_to_user %s:%u\n", __func__, __LINE__);
          return -EFAULT;
      }

Re: [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

[Alex Deucher]

Applied.  Thanks.  I've applied all the patches you sent out, but all
of them had whitespace problems.  Please double check your mailer on
any future submissions.

Thanks,

Alex

On Mon, Jul 10, 2023 at 6:03 AM <sunran001@208suo.com> wrote:
>
> Fix five occurrences of the checkpatch.pl error:
> ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   drivers/gpu/drm/radeon/radeon_kms.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_kms.c
> b/drivers/gpu/drm/radeon/radeon_kms.c
> index e0214cf1b43b..a16590c6247f 100644
> --- a/drivers/gpu/drm/radeon/radeon_kms.c
> +++ b/drivers/gpu/drm/radeon/radeon_kms.c
> @@ -444,7 +444,7 @@ int radeon_info_ioctl(struct drm_device *dev, void
> *data, struct drm_file *filp)
>               DRM_DEBUG_KMS("timestamp is r6xx+ only!\n");
>               return -EINVAL;
>           }
> -        value = (uint32_t*)&value64;
> +        value = (uint32_t *)&value64;
>           value_size = sizeof(uint64_t);
>           value64 = radeon_get_gpu_clock_counter(rdev);
>           break;
> @@ -543,18 +543,18 @@ int radeon_info_ioctl(struct drm_device *dev, void
> *data, struct drm_file *filp)
>           *value = rdev->vce.fb_version;
>           break;
>       case RADEON_INFO_NUM_BYTES_MOVED:
> -        value = (uint32_t*)&value64;
> +        value = (uint32_t *)&value64;
>           value_size = sizeof(uint64_t);
>           value64 = atomic64_read(&rdev->num_bytes_moved);
>           break;
>       case RADEON_INFO_VRAM_USAGE:
> -        value = (uint32_t*)&value64;
> +        value = (uint32_t *)&value64;
>           value_size = sizeof(uint64_t);
>           man = ttm_manager_type(&rdev->mman.bdev, TTM_PL_VRAM);
>           value64 = ttm_resource_manager_usage(man);
>           break;
>       case RADEON_INFO_GTT_USAGE:
> -        value = (uint32_t*)&value64;
> +        value = (uint32_t *)&value64;
>           value_size = sizeof(uint64_t);
>           man = ttm_manager_type(&rdev->mman.bdev, TTM_PL_TT);
>           value64 = ttm_resource_manager_usage(man);
> @@ -614,7 +614,7 @@ int radeon_info_ioctl(struct drm_device *dev, void
> *data, struct drm_file *filp)
>           DRM_DEBUG_KMS("Invalid request %d\n", info->request);
>           return -EINVAL;
>       }
> -    if (copy_to_user(value_ptr, (char*)value, value_size)) {
> +    if (copy_to_user(value_ptr, (char *)value, value_size)) {
>           DRM_ERROR("copy_to_user %s:%u\n", __func__, __LINE__);
>           return -EFAULT;
>       }

[PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

[sunran001]

Fix four occurrences of the checkpatch.pl error:
ERROR: "(foo*)" should be "(foo *)"

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  drivers/gpu/drm/radeon/radeon_test.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_test.c 
b/drivers/gpu/drm/radeon/radeon_test.c
index a5e1d2139e80..c9fef9b61ced 100644
--- a/drivers/gpu/drm/radeon/radeon_test.c
+++ b/drivers/gpu/drm/radeon/radeon_test.c
@@ -156,10 +156,10 @@ static void radeon_do_test_moves(struct 
radeon_device *rdev, int flag)
                        i, *vram_start, gtt_start,
                        (unsigned long long)
                        (gtt_addr - rdev->mc.gtt_start +
-                       (void*)gtt_start - gtt_map),
+                       (void *)gtt_start - gtt_map),
                        (unsigned long long)
                        (vram_addr - rdev->mc.vram_start +
-                       (void*)gtt_start - gtt_map));
+                       (void *)gtt_start - gtt_map));
                  radeon_bo_kunmap(vram_obj);
                  goto out_lclean_unpin;
              }
@@ -207,10 +207,10 @@ static void radeon_do_test_moves(struct 
radeon_device *rdev, int flag)
                        i, *gtt_start, vram_start,
                        (unsigned long long)
                        (vram_addr - rdev->mc.vram_start +
-                       (void*)vram_start - vram_map),
+                       (void *)vram_start - vram_map),
                        (unsigned long long)
                        (gtt_addr - rdev->mc.gtt_start +
-                       (void*)vram_start - vram_map));
+                       (void *)vram_start - vram_map));
                  radeon_bo_kunmap(gtt_obj[i]);
                  goto out_lclean_unpin;
              }

Re: [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

[Alex Deucher]

Applied.  Thanks!

Alex

On Mon, Jul 10, 2023 at 3:52 AM <sunran001@208suo.com> wrote:
>
> Fix four occurrences of the checkpatch.pl error:
> ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   drivers/gpu/drm/radeon/radeon_test.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_test.c
> b/drivers/gpu/drm/radeon/radeon_test.c
> index a5e1d2139e80..c9fef9b61ced 100644
> --- a/drivers/gpu/drm/radeon/radeon_test.c
> +++ b/drivers/gpu/drm/radeon/radeon_test.c
> @@ -156,10 +156,10 @@ static void radeon_do_test_moves(struct
> radeon_device *rdev, int flag)
>                         i, *vram_start, gtt_start,
>                         (unsigned long long)
>                         (gtt_addr - rdev->mc.gtt_start +
> -                       (void*)gtt_start - gtt_map),
> +                       (void *)gtt_start - gtt_map),
>                         (unsigned long long)
>                         (vram_addr - rdev->mc.vram_start +
> -                       (void*)gtt_start - gtt_map));
> +                       (void *)gtt_start - gtt_map));
>                   radeon_bo_kunmap(vram_obj);
>                   goto out_lclean_unpin;
>               }
> @@ -207,10 +207,10 @@ static void radeon_do_test_moves(struct
> radeon_device *rdev, int flag)
>                         i, *gtt_start, vram_start,
>                         (unsigned long long)
>                         (vram_addr - rdev->mc.vram_start +
> -                       (void*)vram_start - vram_map),
> +                       (void *)vram_start - vram_map),
>                         (unsigned long long)
>                         (gtt_addr - rdev->mc.gtt_start +
> -                       (void*)vram_start - vram_map));
> +                       (void *)vram_start - vram_map));
>                   radeon_bo_kunmap(gtt_obj[i]);
>                   goto out_lclean_unpin;
>               }