From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Ryan Roberts <ryan.roberts@arm.com>,
linux-arm-kernel@lists.infradead.org
Cc: Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
James Morse <james.morse@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] arm64/mm: Drop PXD_TABLE_BIT
Date: Tue, 15 Oct 2024 12:17:47 +0530 [thread overview]
Message-ID: <0d3f7e60-48e3-4b02-90d7-207868d3311f@arm.com> (raw)
In-Reply-To: <0ef88192-2523-418f-8ab7-442766a1c444@arm.com>
On 10/9/24 19:02, Ryan Roberts wrote:
> On 05/10/2024 13:38, Anshuman Khandual wrote:
>> Clearing PXD_TABLE_BIT i.e bit[1] on a page table entry always operates on
>> the assumption that subsequent PXD_VALID i.e bit[0] is set. That's because
>> bits[1:0]="01" makes a block mapping. So it is prudent to treat bits[1:0]
>> as a single register field, which should be updated as block or table etc.
>> Although mk_[pmd|pud]_sect_prot() helpers go to some extent in using these
>> PXD_TYPE_SECT macros, their usage is not really consistent else where.
>>
>> This series removes these table bit clearing for block mapping creation and
>> eventually completely drops off those table macros.
> Given the issue I just noticed in patch 2, I'm not sure if it's going to be
> practical to remove the table bit after all? Sorry I didn't spot this before.
Now that arch_make_huge_pte() seems to be all good in patch 1, and there might
be a solution for pmd_present() via de-coupled pmd_mkinvalid(), would it still
not possible to drop PXD_TABLE_BIT ?
prev parent reply other threads:[~2024-10-15 6:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 12:38 Anshuman Khandual
2024-10-05 12:38 ` [PATCH 1/5] arm64/mm: Drop pte_mkhuge() Anshuman Khandual
2024-10-09 13:20 ` Ryan Roberts
2024-10-14 8:59 ` Anshuman Khandual
2024-10-14 11:08 ` Ryan Roberts
2024-10-15 4:23 ` Anshuman Khandual
2024-10-05 12:38 ` [PATCH 2/5] arm64/mm: Replace PXD_TABLE_BIT with PXD_TYPE_[MASK|SECT] Anshuman Khandual
2024-10-09 13:28 ` Ryan Roberts
2024-10-14 10:48 ` Anshuman Khandual
2024-10-14 11:33 ` Ryan Roberts
2024-10-15 3:50 ` Anshuman Khandual
2024-10-05 12:38 ` [PATCH 3/5] arm64/ptdump: Test PMD_TYPE_MASK for block mapping Anshuman Khandual
2024-10-09 13:29 ` Ryan Roberts
2024-10-05 12:38 ` [PATCH 4/5] KVM: arm64: ptdump: " Anshuman Khandual
2024-10-09 13:30 ` Ryan Roberts
2024-10-05 12:38 ` [PATCH 5/5] arm64/mm: Drop PXD_TABLE_BIT Anshuman Khandual
2024-10-09 13:32 ` [PATCH 0/5] " Ryan Roberts
2024-10-15 6:47 ` Anshuman Khandual [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d3f7e60-48e3-4b02-90d7-207868d3311f@arm.com \
--to=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®