From: Markus Elfring <Markus.Elfring@web.de>
To: Jarkko Sakkinen <jarkko@kernel.org>,
kernel-janitors@vger.kernel.org, linux-integrity@vger.kernel.org
Cc: "Dan Carpenter" <error27@gmail.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Peter Hüwe" <peterhuewe@gmx.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: clean up error checking in setup_ring()
Date: Mon, 12 Oct 2026 10:03:09 +0200 [thread overview]
Message-ID: <0d6f94f0-208d-4cf8-a973-2afd37695690@web.de> (raw)
In-Reply-To: <asvSXjQQ0vEvF7yL@kernel.org>
>>> The bind_evtchn_to_irqhandler() function can never return 0.
…
> I do agree that something in this patch does not appear right, or
> at least not very well explained so it is a good catch anyhow.
>
> My decision on this is that:
>
> 1. I'll drop the current patch as it actually does not make a case
> why zero could not possibly happen. I spent 45 minutes browsing
> because commit message did not have any technical details.…
How does this response fit to your previous tag “Reviewed-by”?
Dan Carpenter provided also some hints.
Regards,
Markus
next prev parent reply other threads:[~2026-10-12 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 14:44 Dan Carpenter
2026-10-02 23:31 ` Jarkko Sakkinen
2026-10-05 3:43 ` Jarkko Sakkinen
2026-10-11 9:30 ` Markus Elfring
2026-10-11 18:15 ` Jarkko Sakkinen
2026-10-12 8:03 ` Markus Elfring [this message]
2026-10-12 13:09 ` Jarkko Sakkinen
2026-10-12 13:30 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d6f94f0-208d-4cf8-a973-2afd37695690@web.de \
--to=markus.elfring@web.de \
--cc=error27@gmail.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®