mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: "Dan Carpenter" <error27@gmail.com>,
	kernel-janitors@vger.kernel.org, linux-integrity@vger.kernel.org,
	"Jarkko Sakkinen" <jarkko@kernel.org>,
	"Peter Hüwe" <peterhuewe@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH] tpm: clean up error checking in setup_ring()
Date: Sun, 11 Oct 2026 11:30:13 +0200	[thread overview]
Message-ID: <74850205-dba2-4a97-951d-cda28be129c9@web.de> (raw)
In-Reply-To: <ar_DUjuGv-9vPzga@stanley.mountain>

> The bind_evtchn_to_irqhandler() function can never return 0.
…

I suggest to reconsider information once more also according to the probability
of return values from such a function.
https://elixir.bootlin.com/linux/v7.3-rc6/source/drivers/xen/events/events_base.c#L1453-L1461

bind_evtchn_to_irqhandler_chip()
https://elixir.bootlin.com/linux/v7.3-rc6/source/drivers/xen/events/events_base.c#L1432-L1451


…
> ---
> From static analysis.  Untested.
> 
>  drivers/char/tpm/xen-tpmfront.c | 2 +-
…

Would you be looking for further collateral evolution?
https://elixir.bootlin.com/linux/v7.3-rc6/source/drivers/char/tpm/xen-tpmfront.c#L267-L272

Regards,
Markus

  parent reply	other threads:[~2026-10-11  9:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 14:44 Dan Carpenter
2026-10-02 23:31 ` Jarkko Sakkinen
2026-10-05  3:43 ` Jarkko Sakkinen
2026-10-11  9:30 ` Markus Elfring [this message]
2026-10-11 18:15   ` Jarkko Sakkinen
2026-10-12  8:03     ` Markus Elfring
2026-10-12 13:09       ` Jarkko Sakkinen
2026-10-12 13:30         ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74850205-dba2-4a97-951d-cda28be129c9@web.de \
    --to=markus.elfring@web.de \
    --cc=error27@gmail.com \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®