mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: lemans: pmic: enable rtc
@ 2025-09-25  7:48 Tingguo Cheng
  2025-09-25 11:34 ` Konrad Dybcio
  0 siblings, 1 reply; 3+ messages in thread
From: Tingguo Cheng @ 2025-09-25  7:48 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, kernel, Kamal Wadhwa,
	Rakesh Kota, Tingguo Cheng

Add RTC node, the RTC is controlled by PMIC device via spmi bus.

Signed-off-by: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/lemans-pmics.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
index 1369c3d43f866de9d8cd5cd4985241b99c0a0454..9e0d05c1b39ce229d5d4310ea1df1bf02e689178 100644
--- a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
@@ -132,6 +132,13 @@ pmm8654au_0_pon_resin: resin {
 			};
 		};
 
+		pmm8654au_0_rtc: rtc@6100 {
+			compatible = "qcom,pmk8350-rtc";
+			reg = <0x6100>, <0x6200>;
+			reg-names = "rtc", "alarm";
+			interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
+		};
+
 		pmm8654au_0_gpios: gpio@8800 {
 			compatible = "qcom,pmm8654au-gpio", "qcom,spmi-gpio";
 			reg = <0x8800>;

---
base-commit: 8f458a3ce73750c16af26aa154becb22bdf3bb0b
change-id: 20250924-add-rtc-for-lemans-cedb3e630c4c

Best regards,
-- 
Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: lemans: pmic: enable rtc
  2025-09-25  7:48 [PATCH] arm64: dts: qcom: lemans: pmic: enable rtc Tingguo Cheng
@ 2025-09-25 11:34 ` Konrad Dybcio
  2025-10-17  3:26   ` Tingguo Cheng
  0 siblings, 1 reply; 3+ messages in thread
From: Konrad Dybcio @ 2025-09-25 11:34 UTC (permalink / raw)
  To: Tingguo Cheng, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, kernel, Kamal Wadhwa,
	Rakesh Kota

On 9/25/25 9:48 AM, Tingguo Cheng wrote:
> Add RTC node, the RTC is controlled by PMIC device via spmi bus.

subject: "arm64: dts: qcom: lemans-pmics: foo"

(following the style for the directory)
> 
> Signed-off-by: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/lemans-pmics.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
> index 1369c3d43f866de9d8cd5cd4985241b99c0a0454..9e0d05c1b39ce229d5d4310ea1df1bf02e689178 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
> @@ -132,6 +132,13 @@ pmm8654au_0_pon_resin: resin {
>  			};
>  		};
>  
> +		pmm8654au_0_rtc: rtc@6100 {
> +			compatible = "qcom,pmk8350-rtc";
> +			reg = <0x6100>, <0x6200>;
> +			reg-names = "rtc", "alarm";

1 reg and name a line, please

> +			interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;

Do we not need "qcom,no-alarm" on lemans?

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: lemans: pmic: enable rtc
  2025-09-25 11:34 ` Konrad Dybcio
@ 2025-10-17  3:26   ` Tingguo Cheng
  0 siblings, 0 replies; 3+ messages in thread
From: Tingguo Cheng @ 2025-10-17  3:26 UTC (permalink / raw)
  To: Konrad Dybcio, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Tingguo Cheng, linux-arm-msm, devicetree, linux-kernel, kernel,
	Kamal Wadhwa, Rakesh Kota


On 9/25/2025 7:34 PM, Konrad Dybcio wrote:
> On 9/25/25 9:48 AM, Tingguo Cheng wrote:
>> Add RTC node, the RTC is controlled by PMIC device via spmi bus.
> subject: "arm64: dts: qcom: lemans-pmics: foo"
>
> (following the style for the directory)
Posted v2 to modify this.
>> Signed-off-by: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
>> ---
>>   arch/arm64/boot/dts/qcom/lemans-pmics.dtsi | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
>> index 1369c3d43f866de9d8cd5cd4985241b99c0a0454..9e0d05c1b39ce229d5d4310ea1df1bf02e689178 100644
>> --- a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
>> @@ -132,6 +132,13 @@ pmm8654au_0_pon_resin: resin {
>>   			};
>>   		};
>>   
>> +		pmm8654au_0_rtc: rtc@6100 {
>> +			compatible = "qcom,pmk8350-rtc";
>> +			reg = <0x6100>, <0x6200>;
>> +			reg-names = "rtc", "alarm";
> 1 reg and name a line, please
Posted v2 for this: 
https://lore.kernel.org/all/20251017-add-rtc-for-lemans-v2-1-0aaf174b25b9@oss.qualcomm.com/
 >> +			interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
> Do we not need "qcom,no-alarm" on lemans?

No, it's not needed on lemans. "no-alarm" is only needed on compute 
targets where windows TAD feature will support it.

>
> Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-17  3:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-25  7:48 [PATCH] arm64: dts: qcom: lemans: pmic: enable rtc Tingguo Cheng
2025-09-25 11:34 ` Konrad Dybcio
2025-10-17  3:26   ` Tingguo Cheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®