mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kamil Konieczny <k.konieczny@partner.samsung.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Joakim Bech <joakim.bech@linaro.org>
Subject: Re: [PATCH] crypto: ux500/hash: Add empty export and import
Date: Thu, 18 Jan 2018 18:53:51 +0100	[thread overview]
Message-ID: <0ded4dca-e253-5a88-3f23-a7e5764ca2cb@partner.samsung.com> (raw)
In-Reply-To: <a83d9022-b8bc-ea50-0707-5812f2306b8e@partner.samsung.com>

Please drop this as I will resend it as part of patchset.

On 16.01.2018 17:32, Kamil Konieczny wrote:
> Crypto framework will require async hash export/import, so add empty
> functions to prevent OOPS.
> 
> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
> ---
>  drivers/crypto/ux500/hash/hash_core.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/crypto/ux500/hash/hash_core.c b/drivers/crypto/ux500/hash/hash_core.c
> index 9acccad26928..2d0a677bcc76 100644
> --- a/drivers/crypto/ux500/hash/hash_core.c
> +++ b/drivers/crypto/ux500/hash/hash_core.c
> @@ -1403,6 +1403,16 @@ static int ahash_sha256_digest(struct ahash_request *req)
>  	return ret1 ? ret1 : ret2;
>  }
>  
> +static int ahash_noimport(struct ahash_request *req, const void *in)
> +{
> +	return -ENOSYS;
> +}
> +
> +static int ahash_noexport(struct ahash_request *req, void *out)
> +{
> +	return -ENOSYS;
> +}
> +
>  static int hmac_sha1_init(struct ahash_request *req)
>  {
>  	struct crypto_ahash *tfm = crypto_ahash_reqtfm(req);
> @@ -1507,6 +1517,8 @@ static struct hash_algo_template hash_algs[] = {
>  			.update = ahash_update,
>  			.final = ahash_final,
>  			.digest = ahash_sha1_digest,
> +			.export = ahash_noexport,
> +			.import = ahash_noimport,
>  			.halg.digestsize = SHA1_DIGEST_SIZE,
>  			.halg.statesize = sizeof(struct hash_ctx),
>  			.halg.base = {
> @@ -1529,6 +1541,8 @@ static struct hash_algo_template hash_algs[] = {
>  			.update	= ahash_update,
>  			.final = ahash_final,
>  			.digest = ahash_sha256_digest,
> +			.export = ahash_noexport,
> +			.import = ahash_noimport,
>  			.halg.digestsize = SHA256_DIGEST_SIZE,
>  			.halg.statesize = sizeof(struct hash_ctx),
>  			.halg.base = {
> @@ -1553,6 +1567,8 @@ static struct hash_algo_template hash_algs[] = {
>  			.final = ahash_final,
>  			.digest = hmac_sha1_digest,
>  			.setkey = hmac_sha1_setkey,
> +			.export = ahash_noexport,
> +			.import = ahash_noimport,
>  			.halg.digestsize = SHA1_DIGEST_SIZE,
>  			.halg.statesize = sizeof(struct hash_ctx),
>  			.halg.base = {
> @@ -1577,6 +1593,8 @@ static struct hash_algo_template hash_algs[] = {
>  			.final = ahash_final,
>  			.digest = hmac_sha256_digest,
>  			.setkey = hmac_sha256_setkey,
> +			.export = ahash_noexport,
> +			.import = ahash_noimport,
>  			.halg.digestsize = SHA256_DIGEST_SIZE,
>  			.halg.statesize = sizeof(struct hash_ctx),
>  			.halg.base = {
> 

-- 
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland

      parent reply	other threads:[~2018-01-18 17:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180116163219eucas1p132fafc2db8cb9b3af1a1f22d8bf2fdaf@eucas1p1.samsung.com>
2018-01-16 16:32 ` Kamil Konieczny
2018-01-18 10:06   ` Linus Walleij
2018-01-18 12:52     ` Kamil Konieczny
2018-01-18 17:53   ` Kamil Konieczny [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ded4dca-e253-5a88-3f23-a7e5764ca2cb@partner.samsung.com \
    --to=k.konieczny@partner.samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=joakim.bech@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®