From: Xin Li <xin@zytor.com>
To: Brian Gerst <brgerst@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
will@kernel.org, peterz@infradead.org, akpm@linux-foundation.org,
acme@kernel.org, namhyung@kernel.org
Subject: Re: [PATCH v3 4/4] x86/cpufeatures: Use AWK to generate {REQUIRED|DISABLED}_MASK_BIT_SET
Date: Thu, 27 Jun 2024 09:51:38 -0700 [thread overview]
Message-ID: <0e4e71c7-9cbe-460f-85c7-8bacae8cca57@zytor.com> (raw)
In-Reply-To: <CAMzpN2hMP8c9PXy=0YV4Ln+u_1n1spJP2jaYXKzEABWLh0+hkQ@mail.gmail.com>
On 6/23/2024 1:28 PM, Brian Gerst wrote:
> On Sat, Jun 22, 2024 at 1:14 PM Xin Li (Intel) <xin@zytor.com> wrote:
>>
>> Generate macros {REQUIRED|DISABLED}_MASK_BIT_SET in the newly added AWK
>> script that generates the required and disabled feature mask header.
>>
>> Suggested-by: Brian Gerst <brgerst@gmail.com>
>> Signed-off-by: Xin Li (Intel) <xin@zytor.com>
>> ---
> Checking NCAPINTS isn't necessary anymore. It was needed when these
> macros had to be manually updated, but now if cpufeatures.h changes
> this header will be regenerated.
>
>> }
>>
>> printf "#endif /* _ASM_X86_FEATUREMASKS_H */\n";
>> --
>> 2.45.2
>>
>
> Otherwise, it looks good.
>
Do you mind to give a review-by?
Thanks!
Xin
next prev parent reply other threads:[~2024-06-27 16:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 17:14 [PATCH v3 0/4] x86/cpufeatures: Automatically generate required and disabled feature masks Xin Li (Intel)
2024-06-22 17:14 ` [PATCH v3 1/4] x86/cpufeatures: Add {required,disabled} feature configs Xin Li (Intel)
2024-06-22 17:14 ` [PATCH v3 2/4] x86/cpufeatures: Generate a feature mask header based on build config Xin Li (Intel)
2024-06-26 11:36 ` Nikolay Borisov
2024-06-27 16:45 ` Xin Li
2024-06-22 17:14 ` [PATCH v3 3/4] x86/cpufeatures: Remove {disabled,required}-features.h Xin Li (Intel)
2024-06-22 17:14 ` [PATCH v3 4/4] x86/cpufeatures: Use AWK to generate {REQUIRED|DISABLED}_MASK_BIT_SET Xin Li (Intel)
2024-06-23 20:28 ` Brian Gerst
2024-06-24 7:29 ` Xin Li
2024-06-24 10:24 ` Andrew Cooper
2024-06-24 17:42 ` Xin Li
2024-06-25 5:22 ` [PATCH v3B " Xin Li (Intel)
2024-06-27 18:39 ` Brian Gerst
2024-06-24 9:32 ` [PATCH v3A " Xin Li (Intel)
2024-06-27 16:51 ` Xin Li [this message]
2024-06-22 17:31 ` [PATCH v3 0/4] x86/cpufeatures: Automatically generate required and disabled feature masks Xin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e4e71c7-9cbe-460f-85c7-8bacae8cca57@zytor.com \
--to=xin@zytor.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®