mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Richard Cochran <richardcochran@gmail.com>,
	kernel@collabora.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
	Jianguo Zhang <jianguo.zhang@mediatek.com>,
	Macpaul Lin <macpaul.lin@mediatek.com>,
	Hsuan-Yu Lin <shane.lin@canonical.com>,
	Pablo Sun <pablo.sun@mediatek.com>,
	fanyi zhang <fanyi.zhang@mediatek.com>
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: mt8390-genio-700-evk: Enable ethernet
Date: Wed, 16 Oct 2024 01:01:49 +0200	[thread overview]
Message-ID: <0e72a636-19e1-4f2d-8ea2-f1666c525400@lunn.ch> (raw)
In-Reply-To: <20241015-genio700-eth-v1-2-16a1c9738cf4@collabora.com>

> +&eth {
> +	phy-mode ="rgmii-rxid";
> +	phy-handle = <&ethernet_phy0>;
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&eth_default_pins>;
> +	pinctrl-1 = <&eth_sleep_pins>;
> +	snps,reset-gpio = <&pio 147 GPIO_ACTIVE_HIGH>;
> +	snps,reset-delays-us = <0 10000 10000>;
> +	mediatek,tx-delay-ps = <2030>;

Can you set phy-mode to rgmii-id, and remove the tx-delay-ps property?

    Andrew

  reply	other threads:[~2024-10-15 23:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 18:15 [PATCH 0/2] Enable Ethernet on the Genio 700 EVK board Nícolas F. R. A. Prado
2024-10-15 18:15 ` [PATCH 1/2] arm64: dts: mediatek: mt8188: Add ethernet node Nícolas F. R. A. Prado
2024-10-16 10:39   ` AngeloGioacchino Del Regno
2024-10-15 18:15 ` [PATCH 2/2] arm64: dts: mediatek: mt8390-genio-700-evk: Enable ethernet Nícolas F. R. A. Prado
2024-10-15 23:01   ` Andrew Lunn [this message]
2024-10-16 10:41   ` AngeloGioacchino Del Regno
2024-10-16 12:39   ` Andrew Lunn
2024-10-16 15:38 ` [PATCH 0/2] Enable Ethernet on the Genio 700 EVK board Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e72a636-19e1-4f2d-8ea2-f1666c525400@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fanyi.zhang@mediatek.com \
    --cc=jianguo.zhang@mediatek.com \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=macpaul.lin@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nfraprado@collabora.com \
    --cc=pablo.sun@mediatek.com \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=shane.lin@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®