* [PATCH] drm/amdgpu: clean function declarations in amdgpu_ttm.c up
@ 2016-09-15 13:43 Baoyou Xie
2016-09-15 13:49 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Baoyou Xie @ 2016-09-15 13:43 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, David1.Zhou,
Monk.Liu, Rex.Zhu, JinHuiEric.Huang, Flora.Cui, michel.daenzer
Cc: dri-devel, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:985:5: warning: no previous prototype for 'amdgpu_ttm_init' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1092:6: warning: no previous prototype for 'amdgpu_ttm_fini' [-Wmissing-prototypes]
In fact, both functions are declared in
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c, but should be declared in
a header file, thus can be recognized in other file.
So this patch moves the declarations into
drivers/gpu/drm/amd/amdgpu/amdgpu.h.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index a7bb862..3208608 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -2402,6 +2402,8 @@ void amdgpu_gtt_location(struct amdgpu_device *adev, struct amdgpu_mc *mc);
void amdgpu_ttm_set_active_vram_size(struct amdgpu_device *adev, u64 size);
u64 amdgpu_ttm_get_gtt_mem_size(struct amdgpu_device *adev);
int amdgpu_ttm_global_init(struct amdgpu_device *adev);
+int amdgpu_ttm_init(struct amdgpu_device *adev);
+void amdgpu_ttm_fini(struct amdgpu_device *adev);
void amdgpu_program_register_sequence(struct amdgpu_device *adev,
const u32 *registers,
const u32 array_size);
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index b17734e..30f05d8 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -38,8 +38,6 @@
#include "amdgpu_trace.h"
-int amdgpu_ttm_init(struct amdgpu_device *adev);
-void amdgpu_ttm_fini(struct amdgpu_device *adev);
static u64 amdgpu_get_vis_part_size(struct amdgpu_device *adev,
struct ttm_mem_reg *mem)
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: clean function declarations in amdgpu_ttm.c up
2016-09-15 13:43 [PATCH] drm/amdgpu: clean function declarations in amdgpu_ttm.c up Baoyou Xie
@ 2016-09-15 13:49 ` Christian König
2016-09-16 19:30 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2016-09-15 13:49 UTC (permalink / raw)
To: Baoyou Xie, alexander.deucher, airlied, David1.Zhou, Monk.Liu,
Rex.Zhu, JinHuiEric.Huang, Flora.Cui, michel.daenzer
Cc: dri-devel, linux-kernel, arnd, xie.baoyou
Am 15.09.2016 um 15:43 schrieb Baoyou Xie:
> We get 2 warnings when building kernel with W=1:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:985:5: warning: no previous prototype for 'amdgpu_ttm_init' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1092:6: warning: no previous prototype for 'amdgpu_ttm_fini' [-Wmissing-prototypes]
>
> In fact, both functions are declared in
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c, but should be declared in
> a header file, thus can be recognized in other file.
>
> So this patch moves the declarations into
> drivers/gpu/drm/amd/amdgpu/amdgpu.h.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Reviewed-by: Christian König <christian.koenig@amd.com>.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index a7bb862..3208608 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -2402,6 +2402,8 @@ void amdgpu_gtt_location(struct amdgpu_device *adev, struct amdgpu_mc *mc);
> void amdgpu_ttm_set_active_vram_size(struct amdgpu_device *adev, u64 size);
> u64 amdgpu_ttm_get_gtt_mem_size(struct amdgpu_device *adev);
> int amdgpu_ttm_global_init(struct amdgpu_device *adev);
> +int amdgpu_ttm_init(struct amdgpu_device *adev);
> +void amdgpu_ttm_fini(struct amdgpu_device *adev);
> void amdgpu_program_register_sequence(struct amdgpu_device *adev,
> const u32 *registers,
> const u32 array_size);
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index b17734e..30f05d8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -38,8 +38,6 @@
> #include "amdgpu_trace.h"
>
>
> -int amdgpu_ttm_init(struct amdgpu_device *adev);
> -void amdgpu_ttm_fini(struct amdgpu_device *adev);
>
> static u64 amdgpu_get_vis_part_size(struct amdgpu_device *adev,
> struct ttm_mem_reg *mem)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: clean function declarations in amdgpu_ttm.c up
2016-09-15 13:49 ` Christian König
@ 2016-09-16 19:30 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2016-09-16 19:30 UTC (permalink / raw)
To: Christian König
Cc: Baoyou Xie, Deucher, Alexander, Dave Airlie, Chunming Zhou,
monk.liu, Rex Zhu, Eric Huang, Flora Cui, Daenzer, Michel,
xie.baoyou, Arnd Bergmann, LKML, Maling list - DRI developers
On Thu, Sep 15, 2016 at 9:49 AM, Christian König
<christian.koenig@amd.com> wrote:
> Am 15.09.2016 um 15:43 schrieb Baoyou Xie:
>>
>> We get 2 warnings when building kernel with W=1:
>>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:985:5: warning: no previous
>> prototype for 'amdgpu_ttm_init' [-Wmissing-prototypes]
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1092:6: warning: no previous
>> prototype for 'amdgpu_ttm_fini' [-Wmissing-prototypes]
>>
>> In fact, both functions are declared in
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c, but should be declared in
>> a header file, thus can be recognized in other file.
>>
>> So this patch moves the declarations into
>> drivers/gpu/drm/amd/amdgpu/amdgpu.h.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>.
Applied. thanks!
Alex
>
>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 --
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
>> index a7bb862..3208608 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
>> @@ -2402,6 +2402,8 @@ void amdgpu_gtt_location(struct amdgpu_device *adev,
>> struct amdgpu_mc *mc);
>> void amdgpu_ttm_set_active_vram_size(struct amdgpu_device *adev, u64
>> size);
>> u64 amdgpu_ttm_get_gtt_mem_size(struct amdgpu_device *adev);
>> int amdgpu_ttm_global_init(struct amdgpu_device *adev);
>> +int amdgpu_ttm_init(struct amdgpu_device *adev);
>> +void amdgpu_ttm_fini(struct amdgpu_device *adev);
>> void amdgpu_program_register_sequence(struct amdgpu_device *adev,
>> const u32 *registers,
>> const u32 array_size);
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index b17734e..30f05d8 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -38,8 +38,6 @@
>> #include "amdgpu_trace.h"
>> -int amdgpu_ttm_init(struct amdgpu_device *adev);
>> -void amdgpu_ttm_fini(struct amdgpu_device *adev);
>> static u64 amdgpu_get_vis_part_size(struct amdgpu_device *adev,
>> struct ttm_mem_reg *mem)
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-16 19:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-15 13:43 [PATCH] drm/amdgpu: clean function declarations in amdgpu_ttm.c up Baoyou Xie
2016-09-15 13:49 ` Christian König
2016-09-16 19:30 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome