From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 08/12] staging: rtl8192e: Remove unused variable rfAGCControl1 and rfAGCControl2
Date: Sat, 11 Mar 2023 22:52:02 +0100 [thread overview]
Message-ID: <0f191930597517cf88eb6effd4c20a46c99571ad.1678569965.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1678569965.git.philipp.g.hortmann@gmail.com>
Remove unused variable rfAGCControl1 and rfAGCControl2 because they are
just once set and not used. Remove unused constants as well.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 2 --
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 10 ----------
drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 4 ----
3 files changed, 16 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
index d42eac4b6012..a5d99891688d 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
+++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
@@ -107,8 +107,6 @@ struct bb_reg_definition {
u32 rfintfe;
u32 rf3wireOffset;
u32 rfHSSIPara2;
- u32 rfAGCControl1;
- u32 rfAGCControl2;
u32 rfRxIQImbalance;
u32 rfRxAFE;
u32 rfTxIQImbalance;
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index add3de156e09..32806bcc953a 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -373,16 +373,6 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_device *dev)
priv->phy_reg_def[RF90_PATH_C].rfHSSIPara2 = rFPGA0_XC_HSSIParameter2;
priv->phy_reg_def[RF90_PATH_D].rfHSSIPara2 = rFPGA0_XD_HSSIParameter2;
- priv->phy_reg_def[RF90_PATH_A].rfAGCControl1 = rOFDM0_XAAGCCore1;
- priv->phy_reg_def[RF90_PATH_B].rfAGCControl1 = rOFDM0_XBAGCCore1;
- priv->phy_reg_def[RF90_PATH_C].rfAGCControl1 = rOFDM0_XCAGCCore1;
- priv->phy_reg_def[RF90_PATH_D].rfAGCControl1 = rOFDM0_XDAGCCore1;
-
- priv->phy_reg_def[RF90_PATH_A].rfAGCControl2 = rOFDM0_XAAGCCore2;
- priv->phy_reg_def[RF90_PATH_B].rfAGCControl2 = rOFDM0_XBAGCCore2;
- priv->phy_reg_def[RF90_PATH_C].rfAGCControl2 = rOFDM0_XCAGCCore2;
- priv->phy_reg_def[RF90_PATH_D].rfAGCControl2 = rOFDM0_XDAGCCore2;
-
priv->phy_reg_def[RF90_PATH_A].rfRxIQImbalance = rOFDM0_XARxIQImbalance;
priv->phy_reg_def[RF90_PATH_B].rfRxIQImbalance = rOFDM0_XBRxIQImbalance;
priv->phy_reg_def[RF90_PATH_C].rfRxIQImbalance = rOFDM0_XCRxIQImbalance;
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h
index 5062be507a30..d0ea7e06f0f7 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h
@@ -117,13 +117,9 @@
#define rOFDM0_CCADropThreshold 0xc48
#define rOFDM0_ECCAThreshold 0xc4c /* Energy CCA */
#define rOFDM0_XAAGCCore1 0xc50
-#define rOFDM0_XAAGCCore2 0xc54
#define rOFDM0_XBAGCCore1 0xc58
-#define rOFDM0_XBAGCCore2 0xc5c
#define rOFDM0_XCAGCCore1 0xc60
-#define rOFDM0_XCAGCCore2 0xc64
#define rOFDM0_XDAGCCore1 0xc68
-#define rOFDM0_XDAGCCore2 0xc6c
#define rOFDM0_AGCParameter1 0xc70
#define rOFDM0_AGCParameter2 0xc74
#define rOFDM0_AGCRSSITable 0xc78
--
2.39.2
next prev parent reply other threads:[~2023-03-11 21:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 21:50 [PATCH 00/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D starting .._phyreg.h Philipp Hortmann
2023-03-11 21:50 ` [PATCH 01/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D in rtl92e_config_rf Philipp Hortmann
2023-03-11 21:50 ` [PATCH 02/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfs Philipp Hortmann
2023-03-11 21:50 ` [PATCH 03/12] staging: rtl8192e: Remove unused variable rfintfi Philipp Hortmann
2023-03-11 21:51 ` [PATCH 04/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfo and ..fe Philipp Hortmann
2023-03-11 21:51 ` [PATCH 05/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rf3wireOffset Philipp Hortmann
2023-03-11 21:51 ` [PATCH 06/12] staging: rtl8192e: Remove unused variable rfLSSI_Select and rfTxGainStage Philipp Hortmann
2023-03-11 21:51 ` [PATCH 07/12] staging: rtl8192e: Remove unused variable rfHSSIPara1 and rfSwitchControl Philipp Hortmann
2023-03-11 21:52 ` Philipp Hortmann [this message]
2023-03-11 21:52 ` [PATCH 09/12] staging: rtl8192e: Remove unused variable rfRxIQImbalance and rfRxAFE Philipp Hortmann
2023-03-11 21:52 ` [PATCH 10/12] staging: rtl8192e: Remove unused variable rfTxIQImbalance and rfTxAFE Philipp Hortmann
2023-03-11 21:52 ` [PATCH 11/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfLSSIReadBack Philipp Hortmann
2023-03-11 21:52 ` [PATCH 12/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfHSSIPara2 Philipp Hortmann
2023-03-13 4:55 ` [PATCH 00/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D starting .._phyreg.h Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f191930597517cf88eb6effd4c20a46c99571ad.1678569965.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®