mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 02/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfs
Date: Sat, 11 Mar 2023 22:50:44 +0100	[thread overview]
Message-ID: <801d10f460acbf0601c78dee05c7b32f1628f3a8.1678569965.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1678569965.git.philipp.g.hortmann@gmail.com>

Remove unused priv->phy_reg_def[RF90_PATH_C].rfintfs and
priv->phy_reg_def[RF90_PATH_D].rfintfs.
The termination condition for the loop is set to
priv->num_total_rf_path = RTL819X_TOTAL_RF_PATH = 2.
Because of this pPhyReg = &priv->phy_reg_def[eRFPath]; pPhyReg cannot
point to array element 2 for RF90_PATH_C and 3 for RF90_PATH_D.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c    | 2 --
 drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 1 -
 2 files changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index a9e83ba811b0..94b23cb53c36 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -358,8 +358,6 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_device *dev)
 
 	priv->phy_reg_def[RF90_PATH_A].rfintfs = rFPGA0_XAB_RFInterfaceSW;
 	priv->phy_reg_def[RF90_PATH_B].rfintfs = rFPGA0_XAB_RFInterfaceSW;
-	priv->phy_reg_def[RF90_PATH_C].rfintfs = rFPGA0_XCD_RFInterfaceSW;
-	priv->phy_reg_def[RF90_PATH_D].rfintfs = rFPGA0_XCD_RFInterfaceSW;
 
 	priv->phy_reg_def[RF90_PATH_A].rfintfi = rFPGA0_XAB_RFInterfaceRB;
 	priv->phy_reg_def[RF90_PATH_B].rfintfi = rFPGA0_XAB_RFInterfaceRB;
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h
index f846f109ed98..616a4b62d4b9 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h
@@ -69,7 +69,6 @@
 #define rFPGA0_XC_RFInterfaceOE		0x868
 #define rFPGA0_XD_RFInterfaceOE		0x86c
 #define rFPGA0_XAB_RFInterfaceSW	0x870
-#define rFPGA0_XCD_RFInterfaceSW	0x874
 #define rFPGA0_XAB_RFParameter		0x878
 #define rFPGA0_XCD_RFParameter		0x87c
 #define rFPGA0_AnalogParameter1		0x880
-- 
2.39.2


  parent reply	other threads:[~2023-03-11 21:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11 21:50 [PATCH 00/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D starting .._phyreg.h Philipp Hortmann
2023-03-11 21:50 ` [PATCH 01/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D in rtl92e_config_rf Philipp Hortmann
2023-03-11 21:50 ` Philipp Hortmann [this message]
2023-03-11 21:50 ` [PATCH 03/12] staging: rtl8192e: Remove unused variable rfintfi Philipp Hortmann
2023-03-11 21:51 ` [PATCH 04/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfo and ..fe Philipp Hortmann
2023-03-11 21:51 ` [PATCH 05/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rf3wireOffset Philipp Hortmann
2023-03-11 21:51 ` [PATCH 06/12] staging: rtl8192e: Remove unused variable rfLSSI_Select and rfTxGainStage Philipp Hortmann
2023-03-11 21:51 ` [PATCH 07/12] staging: rtl8192e: Remove unused variable rfHSSIPara1 and rfSwitchControl Philipp Hortmann
2023-03-11 21:52 ` [PATCH 08/12] staging: rtl8192e: Remove unused variable rfAGCControl1 and rfAGCControl2 Philipp Hortmann
2023-03-11 21:52 ` [PATCH 09/12] staging: rtl8192e: Remove unused variable rfRxIQImbalance and rfRxAFE Philipp Hortmann
2023-03-11 21:52 ` [PATCH 10/12] staging: rtl8192e: Remove unused variable rfTxIQImbalance and rfTxAFE Philipp Hortmann
2023-03-11 21:52 ` [PATCH 11/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfLSSIReadBack Philipp Hortmann
2023-03-11 21:52 ` [PATCH 12/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfHSSIPara2 Philipp Hortmann
2023-03-13  4:55 ` [PATCH 00/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D starting .._phyreg.h Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=801d10f460acbf0601c78dee05c7b32f1628f3a8.1678569965.git.philipp.g.hortmann@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®