From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 07/12] staging: rtl8192e: Remove unused variable rfHSSIPara1 and rfSwitchControl
Date: Sat, 11 Mar 2023 22:51:49 +0100 [thread overview]
Message-ID: <5f13420ce5598d447aaad0fe43b807467e0a15bb.1678569965.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1678569965.git.philipp.g.hortmann@gmail.com>
Remove unused variable rfHSSIPara1 and rfSwitchControl because they are
just once set and not used. Remove unused constants as well.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 2 --
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 10 ----------
drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 6 ------
3 files changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
index 2236c1aaf335..d42eac4b6012 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
+++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
@@ -106,9 +106,7 @@ struct bb_reg_definition {
u32 rfintfo;
u32 rfintfe;
u32 rf3wireOffset;
- u32 rfHSSIPara1;
u32 rfHSSIPara2;
- u32 rfSwitchControl;
u32 rfAGCControl1;
u32 rfAGCControl2;
u32 rfRxIQImbalance;
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index 87f28718e732..add3de156e09 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -368,21 +368,11 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_device *dev)
priv->phy_reg_def[RF90_PATH_A].rf3wireOffset = rFPGA0_XA_LSSIParameter;
priv->phy_reg_def[RF90_PATH_B].rf3wireOffset = rFPGA0_XB_LSSIParameter;
- priv->phy_reg_def[RF90_PATH_A].rfHSSIPara1 = rFPGA0_XA_HSSIParameter1;
- priv->phy_reg_def[RF90_PATH_B].rfHSSIPara1 = rFPGA0_XB_HSSIParameter1;
- priv->phy_reg_def[RF90_PATH_C].rfHSSIPara1 = rFPGA0_XC_HSSIParameter1;
- priv->phy_reg_def[RF90_PATH_D].rfHSSIPara1 = rFPGA0_XD_HSSIParameter1;
-
priv->phy_reg_def[RF90_PATH_A].rfHSSIPara2 = rFPGA0_XA_HSSIParameter2;
priv->phy_reg_def[RF90_PATH_B].rfHSSIPara2 = rFPGA0_XB_HSSIParameter2;
priv->phy_reg_def[RF90_PATH_C].rfHSSIPara2 = rFPGA0_XC_HSSIParameter2;
priv->phy_reg_def[RF90_PATH_D].rfHSSIPara2 = rFPGA0_XD_HSSIParameter2;
- priv->phy_reg_def[RF90_PATH_A].rfSwitchControl = rFPGA0_XAB_SwitchControl;
- priv->phy_reg_def[RF90_PATH_B].rfSwitchControl = rFPGA0_XAB_SwitchControl;
- priv->phy_reg_def[RF90_PATH_C].rfSwitchControl = rFPGA0_XCD_SwitchControl;
- priv->phy_reg_def[RF90_PATH_D].rfSwitchControl = rFPGA0_XCD_SwitchControl;
-
priv->phy_reg_def[RF90_PATH_A].rfAGCControl1 = rOFDM0_XAAGCCore1;
priv->phy_reg_def[RF90_PATH_B].rfAGCControl1 = rOFDM0_XBAGCCore1;
priv->phy_reg_def[RF90_PATH_C].rfAGCControl1 = rOFDM0_XCAGCCore1;
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h
index b68e84dd003f..5062be507a30 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h
@@ -48,20 +48,14 @@
#define rFPGA0_TxGainStage 0x80c
#define rFPGA0_RFTiming1 0x810
#define rFPGA0_RFTiming2 0x814
-#define rFPGA0_XA_HSSIParameter1 0x820
#define rFPGA0_XA_HSSIParameter2 0x824
-#define rFPGA0_XB_HSSIParameter1 0x828
#define rFPGA0_XB_HSSIParameter2 0x82c
-#define rFPGA0_XC_HSSIParameter1 0x830
#define rFPGA0_XC_HSSIParameter2 0x834
-#define rFPGA0_XD_HSSIParameter1 0x838
#define rFPGA0_XD_HSSIParameter2 0x83c
#define rFPGA0_XA_LSSIParameter 0x840
#define rFPGA0_XB_LSSIParameter 0x844
#define rFPGA0_RFWakeUpParameter 0x850
#define rFPGA0_RFSleepUpParameter 0x854
-#define rFPGA0_XAB_SwitchControl 0x858
-#define rFPGA0_XCD_SwitchControl 0x85c
#define rFPGA0_XA_RFInterfaceOE 0x860
#define rFPGA0_XB_RFInterfaceOE 0x864
#define rFPGA0_XAB_RFInterfaceSW 0x870
--
2.39.2
next prev parent reply other threads:[~2023-03-11 21:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 21:50 [PATCH 00/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D starting .._phyreg.h Philipp Hortmann
2023-03-11 21:50 ` [PATCH 01/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D in rtl92e_config_rf Philipp Hortmann
2023-03-11 21:50 ` [PATCH 02/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfs Philipp Hortmann
2023-03-11 21:50 ` [PATCH 03/12] staging: rtl8192e: Remove unused variable rfintfi Philipp Hortmann
2023-03-11 21:51 ` [PATCH 04/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfo and ..fe Philipp Hortmann
2023-03-11 21:51 ` [PATCH 05/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rf3wireOffset Philipp Hortmann
2023-03-11 21:51 ` [PATCH 06/12] staging: rtl8192e: Remove unused variable rfLSSI_Select and rfTxGainStage Philipp Hortmann
2023-03-11 21:51 ` Philipp Hortmann [this message]
2023-03-11 21:52 ` [PATCH 08/12] staging: rtl8192e: Remove unused variable rfAGCControl1 and rfAGCControl2 Philipp Hortmann
2023-03-11 21:52 ` [PATCH 09/12] staging: rtl8192e: Remove unused variable rfRxIQImbalance and rfRxAFE Philipp Hortmann
2023-03-11 21:52 ` [PATCH 10/12] staging: rtl8192e: Remove unused variable rfTxIQImbalance and rfTxAFE Philipp Hortmann
2023-03-11 21:52 ` [PATCH 11/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfLSSIReadBack Philipp Hortmann
2023-03-11 21:52 ` [PATCH 12/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfHSSIPara2 Philipp Hortmann
2023-03-13 4:55 ` [PATCH 00/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D starting .._phyreg.h Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f13420ce5598d447aaad0fe43b807467e0a15bb.1678569965.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®