mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: Bhumika Goyal <bhumirks@gmail.com>, <julia.lawall@lip6.fr>,
	<khilman@kernel.org>, <linux@armlinux.org.uk>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ARM: davinci: make the function argument as const
Date: Mon, 27 Nov 2017 17:44:06 +0530	[thread overview]
Message-ID: <0f817e2b-2251-7473-a60b-46ff66c0e77e@ti.com> (raw)
In-Reply-To: <1508148504-2771-2-git-send-email-bhumirks@gmail.com>

On Monday 16 October 2017 03:38 PM, Bhumika Goyal wrote:
> Make the function argument of the function davinci_common_init
> as const as it's memory contents are only copied during a
> memcpy call. So, the fields of the structure to which the argument
> soc_info points to never gets modified and therefore the argument can
> be made const.
> Add const to the prototype too.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

The subject line is written too generically. I changed that to

"
ARM: davinci: make argument to davinci_common_init() as const
"

while applying to v4.16/fixes-non-critical

Thanks,
Sekhar

  reply	other threads:[~2017-11-27 12:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 10:08 [PATCH 0/2] ARM: davinci: make function argument and structure const Bhumika Goyal
2017-10-16 10:08 ` [PATCH 1/2] ARM: davinci: make the function argument as const Bhumika Goyal
2017-11-27 12:14   ` Sekhar Nori [this message]
2017-10-16 10:08 ` [PATCH 2/2] ARM: davinci: make davinci_soc_info structures const Bhumika Goyal
2017-11-27 12:42   ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f817e2b-2251-7473-a60b-46ff66c0e77e@ti.com \
    --to=nsekhar@ti.com \
    --cc=bhumirks@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®