mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: Bhumika Goyal <bhumirks@gmail.com>, <julia.lawall@lip6.fr>,
	<khilman@kernel.org>, <linux@armlinux.org.uk>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ARM: davinci: make davinci_soc_info structures const
Date: Mon, 27 Nov 2017 18:12:59 +0530	[thread overview]
Message-ID: <19265c2a-4ae4-a2f8-3ddf-01c2a4c2b11a@ti.com> (raw)
In-Reply-To: <1508148504-2771-3-git-send-email-bhumirks@gmail.com>

On Monday 16 October 2017 03:38 PM, Bhumika Goyal wrote:
> This is a followup patch for [PATCH 1/2].

This line is not relevant once the patch gets committed.

> 
> Make the structures const as they are either passed to the function

Patch description should be readable independent of subject line so we
need to be more specific than "the structures"

> davinci_common_init having the argument as const or their field cpu_clks
> of type struct clk_lookup * is passed to the function davinci_clk_init.
> So, the fields are never modified and the structures can be const. 
> 
> Done using Coccinelle.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

I made fixes to commit description per above and here is the updated text.

"
ARM: davinci: make davinci_soc_info structures const

Make davinci_soc_info structures const as they are either passed to the
function davinci_common_init having the argument as const or their field
cpu_clks of type struct clk_lookup * is passed to the function
davinci_clk_init.

So, the fields are never modified and the structures can be const.

Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
[nsekhar@ti.com: minor commit message adjustment]
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
"

With that I applied the patch to v4.16/fixes-non-critical

Thanks,
Sekhar

      reply	other threads:[~2017-11-27 12:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 10:08 [PATCH 0/2] ARM: davinci: make function argument and structure const Bhumika Goyal
2017-10-16 10:08 ` [PATCH 1/2] ARM: davinci: make the function argument as const Bhumika Goyal
2017-11-27 12:14   ` Sekhar Nori
2017-10-16 10:08 ` [PATCH 2/2] ARM: davinci: make davinci_soc_info structures const Bhumika Goyal
2017-11-27 12:42   ` Sekhar Nori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19265c2a-4ae4-a2f8-3ddf-01c2a4c2b11a@ti.com \
    --to=nsekhar@ti.com \
    --cc=bhumirks@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®