mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [PATCH v2 2/2] arm64: dts: qcom: oneplus-kebab: new device
       [not found] <c14fe062-2e87-4040-b9a8-7d90a04d7a8c@fhannenheim.net>
@ 2026-10-16 16:38 ` Frieder Hannenheim
  0 siblings, 0 replies; 5+ messages in thread
From: Frieder Hannenheim @ 2026-10-16 16:38 UTC (permalink / raw)
  To: Konrad Dybcio, Frieder Hannenheim, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: Robert Oscilowski, Jean-François Bobier, phone-devel,
	linux-arm-msm, devicetree, linux-kernel

Hi Konrad, thanks for the review comments. Replies inline.

On 16.10.26 10:23, Konrad Dybcio wrote:
> On 10/15/26 2:32 PM, Frieder Hannenheim wrote:
>> Add initial device-tree for the OnePlus 8T. Downstream reference is [1].
>>
>> [1] https://github.com/LineageOS/android_kernel_oneplus_sm8250/blob/lineage-23.2/arch/arm64/boot/dts/vendor/oplus/kona-kebab-overlay.dts
>>
>> Signed-off-by: Frieder Hannenheim <git@fhannenheim.net>
>> Co-developed-by: Robert Oscilowski <drgitx@gmail.com>
>> Signed-off-by: Robert Oscilowski <drgitx@gmail.com>
>> ---
>>   Documentation/devicetree/bindings/arm/qcom.yaml   |   1 +
>>   arch/arm64/boot/dts/qcom/Makefile                 |   1 +
>>   arch/arm64/boot/dts/qcom/sm8250-oneplus-kebab.dts | 129 ++++++++++++++++++++++
> 
> Better. Please split off the dt-bindings changes to a separate patch,
> and put it first in the series.
> 
> [...]
> 
> 
>> +&framebuffer {
>> +	width = <1080>;
>> +	height = <2400>;
>> +	stride = <(1080 * 4)>;
> 
> Does the resolution differ between the two devices?

There's 4 devices: 8 (instantnoodle), 8T (kebab), 8 Pro (instantnoodlep)
and 9R (lemonades).

All except the 8 Pro have a 2400x1080 screen, the 8 Pro has a 3168x1440 
screen.

> 
>> +};
>> +
>> +&i2c2 {
>> +	status = "okay";
>> +
>> +	pm8008: pmic@8 {
>> +		compatible = "qcom,pm8008";
> 
> Is it not present on the other one?

The OnePlus 8 doesn't have this according to the downstream dt. >> +	 
reg = <0x8>;
>> +
>> +		interrupt-parent = <&tlmm>;
>> +		interrupts = <112 IRQ_TYPE_EDGE_RISING>;
>> +
>> +		reset-gpios = <&tlmm 93 GPIO_ACTIVE_LOW>;
>> +
>> +		vdd-l1-l2-supply = <&vreg_s8c_1p3>;
>> +		vdd-l3-l4-supply = <&vreg_bob>;
>> +		vdd-l5-supply = <&vreg_bob>;
>> +		vdd-l6-supply = <&vreg_bob>;
>> +		vdd-l7-supply = <&vreg_bob>;
>> +
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&pm8008_default>, <&pm8008_interrupt>;
> 
> nit:
> 
> property-n
> property-names
> 
> in this order, file-wide, please

Will fix

> [...]
> 
>> +&i2c16 {
>> +	status = "okay";
>> +
>> +	fuel-gauge@55 {
>> +		compatible = "ti,bq28z610";
>> +		reg = <0x55>;
>> +		monitored-battery = <&battery>;
>> +	};
> 
> Likewise, is this absent on the other phone?

Not absent but different. The 8T and 9R use two-cell batteries while the 
others only have one cell and use a different fuel gauge.

>> +};
>> +
>> +&tlmm {
>> +	pm8008_default: pm8008-default-state {
>> +		pins = "gpio93";
>> +		function = "gpio";
>> +		bias-pull-up;
>> +		output-high;
> 
> Drop the output-high, the driver will set it for you

Will do.

Frieder

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] arm64: dts: qcom: oneplus-kebab: new device
  2026-10-17 16:46   ` Krzysztof Kozlowski
@ 2026-10-17 18:14     ` Frieder Hannenheim
  0 siblings, 0 replies; 5+ messages in thread
From: Frieder Hannenheim @ 2026-10-17 18:14 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Robert Oscilowski, Jean-François Bobier,
	phone-devel, linux-arm-msm, devicetree, linux-kernel

On 17.10.26 18:46, Krzysztof Kozlowski wrote:
> On Thu, Oct 15, 2026 at 02:32:37PM +0200, Frieder Hannenheim wrote:
>> Add initial device-tree for the OnePlus 8T. Downstream reference is [1].
>>
>> [1] https://github.com/LineageOS/android_kernel_oneplus_sm8250/blob/lineage-23.2/arch/arm64/boot/dts/vendor/oplus/kona-kebab-overlay.dts
>>
>> Signed-off-by: Frieder Hannenheim <git@fhannenheim.net>
>> Co-developed-by: Robert Oscilowski <drgitx@gmail.com>
>> Signed-off-by: Robert Oscilowski <drgitx@gmail.com>
> 
> Your SoB is the last. Please follow closely submitting patches document.
> 
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
> 
> Best regards,
> Krzysztof
Hi Krzysztof,

thanks for pointing this out. I will put my SoB last. I have run 
checkpatch (see the output below) and it has shown me no warnings that I 
deem actionable. (MAINTAINERS does not seem to contain other dt 
maintainers and wrapping the link would break it).

Kind regards,
Frieder

$ ./scripts/checkpatch.pl -g HEAD-3 --strict
> -------------------------------------------------------------------
> Commit 3b78f6c36076 ("dt-bindings: arm: qcom: Document OnePlus 8T")
> -------------------------------------------------------------------
> total: 0 errors, 0 warnings, 0 checks, 7 lines checked
> 
> Commit 3b78f6c36076 ("dt-bindings: arm: qcom: Document OnePlus 8T") has no obvious style problems and is ready for submission.
> ------------------------------------------------------------------------
> Commit 485091777ce8 ("arm64: dts: qcom: Add sm8250-oneplus-common.dtsi")
> ------------------------------------------------------------------------
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #18: 
> new file mode 100644
> 
> total: 0 errors, 1 warnings, 0 checks, 607 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
> 
> Commit 485091777ce8 ("arm64: dts: qcom: Add sm8250-oneplus-common.dtsi") has style problems, please review.
> -------------------------------------------------------------------
> Commit 72db2e5d2c06 ("arm64: dts: qcom: oneplus-kebab: new device")
> -------------------------------------------------------------------
> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> #8: 
> [1] https://github.com/LineageOS/android_kernel_oneplus_sm8250/blob/lineage-23.2/arch/arm64/boot/dts/vendor/oplus/kona-kebab-overlay.dts
> 
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #32: 
> new file mode 100644
> 
> total: 0 errors, 2 warnings, 0 checks, 137 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
> 
> Commit 72db2e5d2c06 ("arm64: dts: qcom: oneplus-kebab: new device") has style problems, please review.
> 
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] arm64: dts: qcom: oneplus-kebab: new device
  2026-10-15 12:32 ` [PATCH v2 2/2] arm64: dts: qcom: oneplus-kebab: new device Frieder Hannenheim
  2026-10-16  8:23   ` Konrad Dybcio
@ 2026-10-17 16:46   ` Krzysztof Kozlowski
  2026-10-17 18:14     ` Frieder Hannenheim
  1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-17 16:46 UTC (permalink / raw)
  To: Frieder Hannenheim
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Robert Oscilowski, Jean-François Bobier,
	phone-devel, linux-arm-msm, devicetree, linux-kernel

On Thu, Oct 15, 2026 at 02:32:37PM +0200, Frieder Hannenheim wrote:
> Add initial device-tree for the OnePlus 8T. Downstream reference is [1].
> 
> [1] https://github.com/LineageOS/android_kernel_oneplus_sm8250/blob/lineage-23.2/arch/arm64/boot/dts/vendor/oplus/kona-kebab-overlay.dts
> 
> Signed-off-by: Frieder Hannenheim <git@fhannenheim.net>
> Co-developed-by: Robert Oscilowski <drgitx@gmail.com>
> Signed-off-by: Robert Oscilowski <drgitx@gmail.com>

Your SoB is the last. Please follow closely submitting patches document.

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] arm64: dts: qcom: oneplus-kebab: new device
  2026-10-15 12:32 ` [PATCH v2 2/2] arm64: dts: qcom: oneplus-kebab: new device Frieder Hannenheim
@ 2026-10-16  8:23   ` Konrad Dybcio
  2026-10-17 16:46   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2026-10-16  8:23 UTC (permalink / raw)
  To: Frieder Hannenheim, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Robert Oscilowski, Jean-François Bobier, phone-devel,
	linux-arm-msm, devicetree, linux-kernel

On 10/15/26 2:32 PM, Frieder Hannenheim wrote:
> Add initial device-tree for the OnePlus 8T. Downstream reference is [1].
> 
> [1] https://github.com/LineageOS/android_kernel_oneplus_sm8250/blob/lineage-23.2/arch/arm64/boot/dts/vendor/oplus/kona-kebab-overlay.dts
> 
> Signed-off-by: Frieder Hannenheim <git@fhannenheim.net>
> Co-developed-by: Robert Oscilowski <drgitx@gmail.com>
> Signed-off-by: Robert Oscilowski <drgitx@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml   |   1 +
>  arch/arm64/boot/dts/qcom/Makefile                 |   1 +
>  arch/arm64/boot/dts/qcom/sm8250-oneplus-kebab.dts | 129 ++++++++++++++++++++++

Better. Please split off the dt-bindings changes to a separate patch,
and put it first in the series.

[...]


> +&framebuffer {
> +	width = <1080>;
> +	height = <2400>;
> +	stride = <(1080 * 4)>;

Does the resolution differ between the two devices?

> +};
> +
> +&i2c2 {
> +	status = "okay";
> +
> +	pm8008: pmic@8 {
> +		compatible = "qcom,pm8008";

Is it not present on the other one?



> +		reg = <0x8>;
> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <112 IRQ_TYPE_EDGE_RISING>;
> +
> +		reset-gpios = <&tlmm 93 GPIO_ACTIVE_LOW>;
> +
> +		vdd-l1-l2-supply = <&vreg_s8c_1p3>;
> +		vdd-l3-l4-supply = <&vreg_bob>;
> +		vdd-l5-supply = <&vreg_bob>;
> +		vdd-l6-supply = <&vreg_bob>;
> +		vdd-l7-supply = <&vreg_bob>;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pm8008_default>, <&pm8008_interrupt>;

nit:

property-n
property-names

in this order, file-wide, please

[...]

> +&i2c16 {
> +	status = "okay";
> +
> +	fuel-gauge@55 {
> +		compatible = "ti,bq28z610";
> +		reg = <0x55>;
> +		monitored-battery = <&battery>;
> +	};

Likewise, is this absent on the other phone?

> +};
> +
> +&tlmm {
> +	pm8008_default: pm8008-default-state {
> +		pins = "gpio93";
> +		function = "gpio";
> +		bias-pull-up;
> +		output-high;

Drop the output-high, the driver will set it for you

Konrad

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] arm64: dts: qcom: oneplus-kebab: new device
  2026-10-15 12:32 [PATCH v2 0/2] Add OnePlus 8T Frieder Hannenheim
@ 2026-10-15 12:32 ` Frieder Hannenheim
  2026-10-16  8:23   ` Konrad Dybcio
  2026-10-17 16:46   ` Krzysztof Kozlowski
  0 siblings, 2 replies; 5+ messages in thread
From: Frieder Hannenheim @ 2026-10-15 12:32 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: Robert Oscilowski, Jean-François Bobier, phone-devel,
	linux-arm-msm, devicetree, linux-kernel, Frieder Hannenheim

Add initial device-tree for the OnePlus 8T. Downstream reference is [1].

[1] https://github.com/LineageOS/android_kernel_oneplus_sm8250/blob/lineage-23.2/arch/arm64/boot/dts/vendor/oplus/kona-kebab-overlay.dts

Signed-off-by: Frieder Hannenheim <git@fhannenheim.net>
Co-developed-by: Robert Oscilowski <drgitx@gmail.com>
Signed-off-by: Robert Oscilowski <drgitx@gmail.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml   |   1 +
 arch/arm64/boot/dts/qcom/Makefile                 |   1 +
 arch/arm64/boot/dts/qcom/sm8250-oneplus-kebab.dts | 129 ++++++++++++++++++++++
 3 files changed, 131 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 50cc18a6ec5e..6e3fdce92798 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1070,6 +1070,7 @@ properties:
               - qcom,qrb5165-rb5
               - qcom,sm8250-hdk
               - qcom,sm8250-mtp
+              - oneplus,kebab
               - samsung,r8q
               - samsung,x1q
               - sony,pdx203-generic
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 6f33c4e2f09c..d8292f681e71 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -356,6 +356,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8150-sony-xperia-kumano-bahamut.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8150-sony-xperia-kumano-griffin.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-hdk.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-mtp.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-oneplus-kebab.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-samsung-r8q.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-samsung-x1q.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-sony-xperia-edo-pdx203.dtb
diff --git a/arch/arm64/boot/dts/qcom/sm8250-oneplus-kebab.dts b/arch/arm64/boot/dts/qcom/sm8250-oneplus-kebab.dts
new file mode 100644
index 000000000000..67996da204c9
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm8250-oneplus-kebab.dts
@@ -0,0 +1,129 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+/dts-v1/;
+
+#include "sm8250-oneplus-common.dtsi"
+
+/ {
+	model = "OnePlus 8T";
+	compatible = "oneplus,kebab", "qcom,sm8250";
+};
+
+&battery {
+	charge-full-design-microamp-hours = <4500000>;
+	energy-full-design-microwatt-hours = <19575000>;
+	voltage-max-design-microvolt = <4350000>;
+};
+
+&framebuffer {
+	width = <1080>;
+	height = <2400>;
+	stride = <(1080 * 4)>;
+};
+
+&i2c2 {
+	status = "okay";
+
+	pm8008: pmic@8 {
+		compatible = "qcom,pm8008";
+		reg = <0x8>;
+
+		interrupt-parent = <&tlmm>;
+		interrupts = <112 IRQ_TYPE_EDGE_RISING>;
+
+		reset-gpios = <&tlmm 93 GPIO_ACTIVE_LOW>;
+
+		vdd-l1-l2-supply = <&vreg_s8c_1p3>;
+		vdd-l3-l4-supply = <&vreg_bob>;
+		vdd-l5-supply = <&vreg_bob>;
+		vdd-l6-supply = <&vreg_bob>;
+		vdd-l7-supply = <&vreg_bob>;
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&pm8008_default>, <&pm8008_interrupt>;
+
+		gpio-controller;
+		#gpio-cells = <2>;
+		gpio-ranges = <&pm8008 0 0 2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+
+		#thermal-sensor-cells = <0>;
+
+		regulators {
+			ldo1 {
+				regulator-name = "vreg_l1p";
+				regulator-min-microvolt = <528000>;
+				regulator-max-microvolt = <1504000>;
+			};
+
+			ldo2 {
+				regulator-name = "vreg_l2p";
+				regulator-min-microvolt = <528000>;
+				regulator-max-microvolt = <1300000>;
+			};
+
+			ldo3 {
+				regulator-name = "vreg_l3p";
+				regulator-min-microvolt = <1500000>;
+				regulator-max-microvolt = <3400000>;
+			};
+
+			ldo4 {
+				regulator-name = "vreg_l4p";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+			};
+
+			ldo5 {
+				regulator-name = "vreg_l5p";
+				regulator-min-microvolt = <1500000>;
+				regulator-max-microvolt = <3400000>;
+			};
+
+			ldo6 {
+				regulator-name = "vreg_l6p";
+				regulator-min-microvolt = <1500000>;
+				regulator-max-microvolt = <3400000>;
+			};
+
+			ldo7 {
+				regulator-name = "vreg_l7p";
+				regulator-min-microvolt = <1500000>;
+				regulator-max-microvolt = <3400000>;
+			};
+		};
+	};
+};
+
+&i2c16 {
+	status = "okay";
+
+	fuel-gauge@55 {
+		compatible = "ti,bq28z610";
+		reg = <0x55>;
+		monitored-battery = <&battery>;
+	};
+};
+
+&tlmm {
+	pm8008_default: pm8008-default-state {
+		pins = "gpio93";
+		function = "gpio";
+		bias-pull-up;
+		output-high;
+		drive-strength = <2>;
+	};
+
+	pm8008_interrupt: pm8008-interrupt {
+		pins = "gpio112";
+		function = "gpio";
+		bias-disable;
+		input-enable;
+	};
+};
+
+&vreg_f {
+	status = "disabled";
+};

-- 
2.54.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-10-17 18:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <c14fe062-2e87-4040-b9a8-7d90a04d7a8c@fhannenheim.net>
2026-10-16 16:38 ` [PATCH v2 2/2] arm64: dts: qcom: oneplus-kebab: new device Frieder Hannenheim
2026-10-15 12:32 [PATCH v2 0/2] Add OnePlus 8T Frieder Hannenheim
2026-10-15 12:32 ` [PATCH v2 2/2] arm64: dts: qcom: oneplus-kebab: new device Frieder Hannenheim
2026-10-16  8:23   ` Konrad Dybcio
2026-10-17 16:46   ` Krzysztof Kozlowski
2026-10-17 18:14     ` Frieder Hannenheim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®