From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: clean up the IDE iops, add ones for a dead iface
Date: 19 Feb 2003 01:53:04 +0000 [thread overview]
Message-ID: <1045619583.25795.11.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20030218230910.A27653@flint.arm.linux.org.uk>
On Tue, 2003-02-18 at 23:09, Russell King wrote:
> On Tue, Feb 18, 2003 at 06:03:21PM +0000, Alan Cox wrote:
> > +static u8 ide_unplugged_inb (unsigned long port)
> > +{
> > + return 0xFF;
> > +}
>
> Shouldn't this return 0x7f, ie bit 7 clear, as if we have an interface
> without drive attached?
0xFF is what most hardware returns for an unclaimed pci address. I'd rather
make sure it also works when we don't get the event, or the device
summarily explodes than fake up something to make it look good. If
0xff doesnt work we have a bug anyway, lets find them.
Alan
next prev parent reply other threads:[~2003-02-19 0:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-18 18:03 Alan Cox
2003-02-18 23:09 ` Russell King
2003-02-19 1:53 ` Alan Cox [this message]
2003-02-19 9:39 ` Benjamin Herrenschmidt
2003-02-19 14:25 ` Alan Cox
2003-02-19 16:56 ` Linus Torvalds
2003-02-19 17:06 ` Benjamin Herrenschmidt
2003-02-19 18:22 ` Alan Cox
2003-02-19 17:26 ` Benjamin Herrenschmidt
2003-02-21 9:13 ` David Woodhouse
2003-02-20 13:16 ` Geert Uytterhoeven
2003-02-20 14:40 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1045619583.25795.11.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®