mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Russell King <rmk@arm.linux.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: clean up the IDE iops, add ones for a dead iface
Date: 19 Feb 2003 18:06:27 +0100	[thread overview]
Message-ID: <1045674387.12533.48.camel@zion.wanadoo.fr> (raw)
In-Reply-To: <Pine.LNX.4.44.0302190853180.18995-100000@home.transmeta.com>

On Wed, 2003-02-19 at 17:56, Linus Torvalds wrote:

> We've seen that before: try unplugging a PCMCIA IDE card unexpectedly. 
> 
> Guess what? It will start returning 0xff. And the machine dies, because 
> the PCMCIA interrupt happened due to the removal event will also be shared 
> by the IDE driver, so the IDE driver will react badly even before anybody 
> has had a chance to tell it that the hardware no longer exists.
> 
> So if you have code that doesn't work with 0xff, then that code is already 
> a-priori buggy. And getting it fixed would be a damn good idea.

Yup, you are right. Removing a disk from a controller shall return
anything with bit 7 at 0 per spec, but removing the controller
itself will return 0xff. Actually, in my "wait for BSY low" loop
I added to the probe code for pmac (should be made generic sooner
or later), I did special case 0xff.

So we should indeed fix the various bits in IDE. 0xff out of
status, I beleive, never means anything and can always be considered
as "this interface is gone".
 
Ben.


  reply	other threads:[~2003-02-19 16:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-18 18:03 Alan Cox
2003-02-18 23:09 ` Russell King
2003-02-19  1:53   ` Alan Cox
2003-02-19  9:39     ` Benjamin Herrenschmidt
2003-02-19 14:25       ` Alan Cox
2003-02-19 16:56       ` Linus Torvalds
2003-02-19 17:06         ` Benjamin Herrenschmidt [this message]
2003-02-19 18:22           ` Alan Cox
2003-02-19 17:26             ` Benjamin Herrenschmidt
2003-02-21  9:13         ` David Woodhouse
2003-02-20 13:16 ` Geert Uytterhoeven
2003-02-20 14:40   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1045674387.12533.48.camel@zion.wanadoo.fr \
    --to=benh@kernel.crashing.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®