From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: clean up the IDE iops, add ones for a dead iface
Date: 20 Feb 2003 14:40:39 +0000 [thread overview]
Message-ID: <1045752038.3790.0.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <Pine.GSO.4.21.0302201415070.18109-100000@vervain.sonytel.be>
On Thu, 2003-02-20 at 13:16, Geert Uytterhoeven wrote:
> On Tue, 18 Feb 2003, Alan Cox wrote:
> > -static void ide_outb (u8 value, ide_ioreg_t port)
> > +static void ide_outb (u8 addr, unsigned long port)
>
> > -static void ide_outw (u16 value, ide_ioreg_t port)
> > +static void ide_outw (u16 addr, unsigned long port)
>
> > -static void ide_outl (u32 value, ide_ioreg_t port)
> > +static void ide_outl (u32 addr, unsigned long port)
>
> The first parameter should be called `value', not `addr'.
Yep. That change missed the base 2.4 tree so it rippled back
into 2.5. I'll fix it up at some point
prev parent reply other threads:[~2003-02-20 13:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-18 18:03 Alan Cox
2003-02-18 23:09 ` Russell King
2003-02-19 1:53 ` Alan Cox
2003-02-19 9:39 ` Benjamin Herrenschmidt
2003-02-19 14:25 ` Alan Cox
2003-02-19 16:56 ` Linus Torvalds
2003-02-19 17:06 ` Benjamin Herrenschmidt
2003-02-19 18:22 ` Alan Cox
2003-02-19 17:26 ` Benjamin Herrenschmidt
2003-02-21 9:13 ` David Woodhouse
2003-02-20 13:16 ` Geert Uytterhoeven
2003-02-20 14:40 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1045752038.3790.0.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®