* [PATCH] Fix V.110 on HiSax HFC_PCI.
@ 2003-04-29 9:28 David Woodhouse
2003-04-29 14:19 ` Kai Germaschewski
0 siblings, 1 reply; 3+ messages in thread
From: David Woodhouse @ 2003-04-29 9:28 UTC (permalink / raw)
To: marcelo; +Cc: kkeil, kai.germaschewski, linux-kernel
This patch fixes V.110 dialin to HFC_PCI ISDN adapters, which weren't
sending V.110 idle frames correctly before due to missing wakeups from
the low-level driver.
This is for 2.4 only -- 2.5 with ISDN doesn't even boot for me at the moment.
--- drivers/isdn/hisax/hfc_pci.c.orig 2003-04-26 00:19:36.000000000 +0100
+++ drivers/isdn/hisax/hfc_pci.c 2003-04-26 00:19:43.000000000 +0100
@@ -687,6 +687,10 @@
debugl1(cs, "hfcpci_fill_fifo_trans %d frame length %d discarded",
bcs->channel, bcs->tx_skb->len);
+ if (bcs->st->lli.l1writewakeup &&
+ (PACKET_NOACK != bcs->tx_skb->pkt_type))
+ bcs->st->lli.l1writewakeup(bcs->st, bcs->tx_skb->len);
+
dev_kfree_skb_any(bcs->tx_skb);
cli();
bcs->tx_skb = skb_dequeue(&bcs->squeue); /* fetch next data */
--
dwmw2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix V.110 on HiSax HFC_PCI.
2003-04-29 9:28 [PATCH] Fix V.110 on HiSax HFC_PCI David Woodhouse
@ 2003-04-29 14:19 ` Kai Germaschewski
2003-04-29 21:16 ` Marcelo Tosatti
0 siblings, 1 reply; 3+ messages in thread
From: Kai Germaschewski @ 2003-04-29 14:19 UTC (permalink / raw)
To: David Woodhouse; +Cc: marcelo, kkeil, linux-kernel
On Tue, 29 Apr 2003, David Woodhouse wrote:
> This patch fixes V.110 dialin to HFC_PCI ISDN adapters, which weren't
> sending V.110 idle frames correctly before due to missing wakeups from
> the low-level driver.
>
> This is for 2.4 only -- 2.5 with ISDN doesn't even boot for me at the moment.
>
> --- drivers/isdn/hisax/hfc_pci.c.orig 2003-04-26 00:19:36.000000000 +0100
> +++ drivers/isdn/hisax/hfc_pci.c 2003-04-26 00:19:43.000000000 +0100
> @@ -687,6 +687,10 @@
> debugl1(cs, "hfcpci_fill_fifo_trans %d frame length %d discarded",
> bcs->channel, bcs->tx_skb->len);
>
> + if (bcs->st->lli.l1writewakeup &&
> + (PACKET_NOACK != bcs->tx_skb->pkt_type))
> + bcs->st->lli.l1writewakeup(bcs->st, bcs->tx_skb->len);
> +
> dev_kfree_skb_any(bcs->tx_skb);
> cli();
> bcs->tx_skb = skb_dequeue(&bcs->squeue); /* fetch next data */
>
Thanks, this looks fine. I'll merge it if Marcelo doesn't take it right
away (please do ;)
--Kai
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix V.110 on HiSax HFC_PCI.
2003-04-29 14:19 ` Kai Germaschewski
@ 2003-04-29 21:16 ` Marcelo Tosatti
0 siblings, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2003-04-29 21:16 UTC (permalink / raw)
To: Kai Germaschewski; +Cc: David Woodhouse, kkeil, linux-kernel
On Tue, 29 Apr 2003, Kai Germaschewski wrote:
> On Tue, 29 Apr 2003, David Woodhouse wrote:
>
> > This patch fixes V.110 dialin to HFC_PCI ISDN adapters, which weren't
> > sending V.110 idle frames correctly before due to missing wakeups from
> > the low-level driver.
> >
> > This is for 2.4 only -- 2.5 with ISDN doesn't even boot for me at the moment.
> >
> > --- drivers/isdn/hisax/hfc_pci.c.orig 2003-04-26 00:19:36.000000000 +0100
> > +++ drivers/isdn/hisax/hfc_pci.c 2003-04-26 00:19:43.000000000 +0100
> > @@ -687,6 +687,10 @@
> > debugl1(cs, "hfcpci_fill_fifo_trans %d frame length %d discarded",
> > bcs->channel, bcs->tx_skb->len);
> >
> > + if (bcs->st->lli.l1writewakeup &&
> > + (PACKET_NOACK != bcs->tx_skb->pkt_type))
> > + bcs->st->lli.l1writewakeup(bcs->st, bcs->tx_skb->len);
> > +
> > dev_kfree_skb_any(bcs->tx_skb);
> > cli();
> > bcs->tx_skb = skb_dequeue(&bcs->squeue); /* fetch next data */
> >
>
> Thanks, this looks fine. I'll merge it if Marcelo doesn't take it right
> away (please do ;)
Done.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-04-29 21:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-29 9:28 [PATCH] Fix V.110 on HiSax HFC_PCI David Woodhouse
2003-04-29 14:19 ` Kai Germaschewski
2003-04-29 21:16 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®