[patch] Re: psmouse.c, throwing 3 bytes away

[patch] Re: psmouse.c, throwing 3 bytes away

[Bob Gill]

Hi.  I rebuilt with your patch and ran while running Fedora Prelink
(actually Fedora was running that on its own) and an FPS (graphics and
mouse intensive).  Did not have any problems even though system load was
over 200%.  Thanks for the good work!  

Bob

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Claudio Martins]

  Hi,

  Just to report that during many hours of desktop use and also some heavier 
use (like quake3 :-), the mouse behaved just fine without any glitches or 
error messages.

  So it seems that the problem is solved with your patch.

  Thanks for your work!

best regards

Claudio

On Monday 09 February 2004 00:48, Vojtech Pavlik wrote:
> On Sat, Feb 07, 2004 at 09:11:42AM +0000, Murilo Pontes wrote:
> > Problem still occurs :-(
>
> And here is a fix. Damn stupid mistake I made.

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Murilo Pontes]

Thanks, 
I tested by 12hours, everything is ok :)
But I want test more few days


Em Seg 09 Fev 2004 00:48, você escreveu:
> On Sat, Feb 07, 2004 at 09:11:42AM +0000, Murilo Pontes wrote:
> 
> > Problem still occurs :-(
> 
> And here is a fix. Damn stupid mistake I made.
> 

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Vojtech Pavlik]

On Tue, Feb 10, 2004 at 01:48:55PM -0600, Greg Norris wrote:
> On Tue, Feb 10, 2004 at 08:07:35AM +0100, Vojtech Pavlik wrote:
> > USB?? This was for PS/2 mice. If it fixed your USB mouse problem, you
> > were using PS/2 drivers with your USB mouse, which is wrong (although it
> > can work). You need to use USB drivers.
> 
> I thought I was... all of the appropriate USB drivers are enabled, and
> I haven't done anything special to load the psmouse module.  I guess
> it's possible that a bootup script is loading it automagically,
> tho.  I'll check into this.

The most suspicious issue here is that not only psmouse gets loaded, but
that it finds a mouse attached! Note that ehci-hcd is not enough, you
also will need either uhci or ohci.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Greg Norris]

On Tue, Feb 10, 2004 at 08:07:35AM +0100, Vojtech Pavlik wrote:
> USB?? This was for PS/2 mice. If it fixed your USB mouse problem, you
> were using PS/2 drivers with your USB mouse, which is wrong (although it
> can work). You need to use USB drivers.

I thought I was... all of the appropriate USB drivers are enabled, and
I haven't done anything special to load the psmouse module.  I guess
it's possible that a bootup script is loading it automagically,
tho.  I'll check into this.

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Walt Nelson]

Thanks for the psmouse.c fix.

Walt

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[johann lombardi]

> And here is a fix. Damn stupid mistake I made.
It solves the problem for me.
Thanks.

Johann

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Vojtech Pavlik]

On Mon, Feb 09, 2004 at 08:56:27PM -0600, Greg Norris wrote:
> On Mon, Feb 09, 2004 at 01:48:12AM +0100, Vojtech Pavlik wrote:
> > And here is a fix. Damn stupid mistake I made.
> 
> This appears to squash my problem as well (the "usb mouse/keyboard
> problems under 2.6.2" thread).  Thanx!!!

USB?? This was for PS/2 mice. If it fixed your USB mouse problem, you
were using PS/2 drivers with your USB mouse, which is wrong (although it
can work). You need to use USB drivers.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Greg Norris]

On Mon, Feb 09, 2004 at 01:48:12AM +0100, Vojtech Pavlik wrote:
> And here is a fix. Damn stupid mistake I made.

This appears to squash my problem as well (the "usb mouse/keyboard
problems under 2.6.2" thread).  Thanx!!!

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Vojtech Pavlik]

On Mon, Feb 09, 2004 at 01:13:23AM +0000, Claudio Martins wrote:
> 
>   Just FYI:
> 
>   CC      drivers/input/serio/i8042.o
> drivers/input/serio/i8042.c: In function `i8042_interrupt':
> drivers/input/serio/i8042.c:378: warning: `data' might be used uninitialized 
> in this function

It can't be used uninitalized. I've fixed this in my tree already, just
ignore the warning for the time being.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Claudio Martins]

  Just FYI:

  CC      drivers/input/serio/i8042.o
drivers/input/serio/i8042.c: In function `i8042_interrupt':
drivers/input/serio/i8042.c:378: warning: `data' might be used uninitialized 
in this function

regards

Claudio


On Monday 09 February 2004 00:48, Vojtech Pavlik wrote:
> On Sat, Feb 07, 2004 at 09:11:42AM +0000, Murilo Pontes wrote:
> > Problem still occurs :-(
>
> And here is a fix. Damn stupid mistake I made.

[patch] Re: psmouse.c, throwing 3 bytes away

[Vojtech Pavlik]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

On Sat, Feb 07, 2004 at 09:11:42AM +0000, Murilo Pontes wrote:

> Problem still occurs :-(

And here is a fix. Damn stupid mistake I made.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

[-- Attachment #2: lost-sync-fix --]
[-- Type: text/plain, Size: 1084 bytes --]

You can pull this changeset from:
	bk://kernel.bkbits.net/vojtech/input

===================================================================

ChangeSet@1.1587, 2004-02-09 01:47:16+01:00, vojtech@suse.cz
  input: Fix "psmouse: Lost sync" problem. It was really losing sync.


 i8042.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

===================================================================

diff -Nru a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
--- a/drivers/input/serio/i8042.c	Mon Feb  9 01:47:46 2004
+++ b/drivers/input/serio/i8042.c	Mon Feb  9 01:47:46 2004
@@ -379,9 +379,12 @@
 	unsigned int dfl;
 	int ret;
 
+	mod_timer(&i8042_timer, jiffies + I8042_POLL_PERIOD);
+
 	spin_lock_irqsave(&i8042_lock, flags);
 	str = i8042_read_status();
-	data = i8042_read_data();
+	if (str & I8042_STR_OBF)
+		data = i8042_read_data();
 	spin_unlock_irqrestore(&i8042_lock, flags);
 
 	if (~str & I8042_STR_OBF) {
@@ -432,7 +435,6 @@
 irq_ret:
 	ret = 1;
 out:
-	mod_timer(&i8042_timer, jiffies + I8042_POLL_PERIOD);
 	return IRQ_RETVAL(ret);
 }