[patch] Re: psmouse.c, throwing 3 bytes away

[patch] Re: psmouse.c, throwing 3 bytes away

[Bob Gill]

Hi.  I rebuilt with your patch and ran while running Fedora Prelink
(actually Fedora was running that on its own) and an FPS (graphics and
mouse intensive).  Did not have any problems even though system load was
over 200%.  Thanks for the good work!  

Bob

psmouse.c, throwing 3 bytes away

[Walt Nelson]

My mouse has been acting wired occationally, not all the time. I receive the 
following error in the syslog. This has been happening since 2.6.2-RC3. I am 
currently using 2.6.2. Are these related?

Feb  4 13:56:02 gumby kernel: psmouse.c: Wheel Mouse at isa0060/serio1/input0 
lost synchronization, throwing 3 bytes away.

The following occurs when starting KDE/X.
Feb  4 18:05:11 gumby kernel: atkbd.c: Unknown key released (translated set 2, 
code 0x7a on isa0060/serio0).
Feb  4 18:05:11 gumby kernel: atkbd.c: This is an XFree86 bug. It shouldn't 
access hardware directly.
Feb  4 18:05:11 gumby kernel: atkbd.c: Unknown key released (translated set 2, 
code 0x7a on isa0060/serio0).
Feb  4 18:05:11 gumby kernel: atkbd.c: This is an XFree86 bug. It shouldn't 
access hardware directly.

Thanks in advance

Walt

Re: psmouse.c, throwing 3 bytes away

[Walt Nelson]

I am not sure but patch-2.6.2-bk1.tar.gz has not produce the mouse problems. I 
applied it about 14 hours ago. I have no seen any mouse problems. I noticed 
that there was a possible fix for loosing ticks in it?

Walt


On Thursday 05 February 2004 11:15 pm, Mike Houston wrote:
> On Thu, 5 Feb 2004 17:10:27 -0500
>
> Mike Houston <mikeserv@bmts.com> wrote:
> > I am using ACPI and IO-APIC. Next time my mouse acts up, I will consider
> > trying 2.6.2 without ACPI and IO-APIC (though I'd hate to lose that
> > functionality). Trouble is it might take a long time for the mouse glitch
> > to occur.
>
> Ok, shortly after posting earlier today, it did indeed happen again with
> 2.6.2. I was just clicking on mails in my sylpheed client. There wasn't
> much load, I wasn't doing anything but reading mails.
>
> So I built another 2.6.2 with acpi and io-apic disabled and ran it for
> about 5 hours and the problem reoccurred. I was just chatting on IRC and
> moved my mouse and it happened. Again, I was doing nothing else so load
> wasn't a factor.
>
> psmouse.c: MX Mouse at isa0060/serio1/input0 lost synchronization, throwing
> 2 bytes away.
>
> Gee whiz, it just happened again while composing this mail :-)
>
> So it doesn't have anything to do with acpi, or being under load for that
> matter, on my system, anyway.
>
> Mike
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: psmouse.c, throwing 3 bytes away

[Mike Houston]

On Fri, 6 Feb 2004 00:06:32 -0800
Walt Nelson <wnelsonjr@comcast.net> wrote:

> I am not sure but patch-2.6.2-bk1.tar.gz has not produce the mouse problems. I 
> applied it about 14 hours ago. I have no seen any mouse problems. I noticed 
> that there was a possible fix for loosing ticks in it?
> 

Well, I've been running 2.6.2-bk2 for around 12 hours now, and the problem hasn't surfaced. While this is the longest I've gone, it still could be coincidence but I'm hoping that strange mouse glitch won't come back.

I'm going to move on to 2.6.3-rc1 now. Here's to having nothing to report :-)

Mike

Re: psmouse.c, throwing 3 bytes away

[Murilo Pontes]

Problem still occurs :-(



09:03:17 [root@murilo:~]#cat /proc/version
Linux version 2.6.3-rc1 (root@murilo) (gcc version 3.3.2) #2 Sat Feb 7 08:24:31 UTC 2004
09:03:20 [root@murilo:~]#
09:03:20 [root@murilo:~]#dmesg | grep psmouse
psmouse.c: Wheel Mouse at isa0060/serio1/input0 lost synchronization, throwing 3 bytes away.
09:03:41 [root@murilo:~]#
09:04:45 [root@murilo:~]#uptime
 09:04:49 up 39 min,  0 users,  load average: 0.08, 0.16, 0.15
09:04:49 [root@murilo:~]#
09:10:46 [root@murilo:~]#dmesg | grep time
Using tsc for high-res timesource
Machine check exception polling timer started.
PCI: Setting latency timer of device 0000:00:04.0 to 64
PCI: Setting latency timer of device 0000:00:02.2 to 64
PCI: Setting latency timer of device 0000:00:02.0 to 64
PCI: Setting latency timer of device 0000:00:02.1 to 64
PCI: Setting latency timer of device 0000:00:06.0 to 64
09:11:11 [root@murilo:~]#


Em Sáb 07 Fev 2004 05:47, Mike Houston escreveu:
> On Fri, 6 Feb 2004 00:06:32 -0800
> Walt Nelson <wnelsonjr@comcast.net> wrote:
> 
> > I am not sure but patch-2.6.2-bk1.tar.gz has not produce the mouse problems. I 
> > applied it about 14 hours ago. I have no seen any mouse problems. I noticed 
> > that there was a possible fix for loosing ticks in it?
> > 
> 
> Well, I've been running 2.6.2-bk2 for around 12 hours now, and the problem hasn't surfaced. While this is the longest I've gone, it still could be coincidence but I'm hoping that strange mouse glitch won't come back.
> 
> I'm going to move on to 2.6.3-rc1 now. Here's to having nothing to report :-)
> 
> Mike
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

[patch] Re: psmouse.c, throwing 3 bytes away

[Vojtech Pavlik]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

On Sat, Feb 07, 2004 at 09:11:42AM +0000, Murilo Pontes wrote:

> Problem still occurs :-(

And here is a fix. Damn stupid mistake I made.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

[-- Attachment #2: lost-sync-fix --]
[-- Type: text/plain, Size: 1084 bytes --]

You can pull this changeset from:
	bk://kernel.bkbits.net/vojtech/input

===================================================================

ChangeSet@1.1587, 2004-02-09 01:47:16+01:00, vojtech@suse.cz
  input: Fix "psmouse: Lost sync" problem. It was really losing sync.


 i8042.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

===================================================================

diff -Nru a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
--- a/drivers/input/serio/i8042.c	Mon Feb  9 01:47:46 2004
+++ b/drivers/input/serio/i8042.c	Mon Feb  9 01:47:46 2004
@@ -379,9 +379,12 @@
 	unsigned int dfl;
 	int ret;
 
+	mod_timer(&i8042_timer, jiffies + I8042_POLL_PERIOD);
+
 	spin_lock_irqsave(&i8042_lock, flags);
 	str = i8042_read_status();
-	data = i8042_read_data();
+	if (str & I8042_STR_OBF)
+		data = i8042_read_data();
 	spin_unlock_irqrestore(&i8042_lock, flags);
 
 	if (~str & I8042_STR_OBF) {
@@ -432,7 +435,6 @@
 irq_ret:
 	ret = 1;
 out:
-	mod_timer(&i8042_timer, jiffies + I8042_POLL_PERIOD);
 	return IRQ_RETVAL(ret);
 }
 

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Claudio Martins]

  Just FYI:

  CC      drivers/input/serio/i8042.o
drivers/input/serio/i8042.c: In function `i8042_interrupt':
drivers/input/serio/i8042.c:378: warning: `data' might be used uninitialized 
in this function

regards

Claudio


On Monday 09 February 2004 00:48, Vojtech Pavlik wrote:
> On Sat, Feb 07, 2004 at 09:11:42AM +0000, Murilo Pontes wrote:
> > Problem still occurs :-(
>
> And here is a fix. Damn stupid mistake I made.

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Vojtech Pavlik]

On Mon, Feb 09, 2004 at 01:13:23AM +0000, Claudio Martins wrote:
> 
>   Just FYI:
> 
>   CC      drivers/input/serio/i8042.o
> drivers/input/serio/i8042.c: In function `i8042_interrupt':
> drivers/input/serio/i8042.c:378: warning: `data' might be used uninitialized 
> in this function

It can't be used uninitalized. I've fixed this in my tree already, just
ignore the warning for the time being.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Greg Norris]

On Mon, Feb 09, 2004 at 01:48:12AM +0100, Vojtech Pavlik wrote:
> And here is a fix. Damn stupid mistake I made.

This appears to squash my problem as well (the "usb mouse/keyboard
problems under 2.6.2" thread).  Thanx!!!

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Vojtech Pavlik]

On Mon, Feb 09, 2004 at 08:56:27PM -0600, Greg Norris wrote:
> On Mon, Feb 09, 2004 at 01:48:12AM +0100, Vojtech Pavlik wrote:
> > And here is a fix. Damn stupid mistake I made.
> 
> This appears to squash my problem as well (the "usb mouse/keyboard
> problems under 2.6.2" thread).  Thanx!!!

USB?? This was for PS/2 mice. If it fixed your USB mouse problem, you
were using PS/2 drivers with your USB mouse, which is wrong (although it
can work). You need to use USB drivers.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Walt Nelson]

Thanks for the psmouse.c fix.

Walt

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Greg Norris]

On Tue, Feb 10, 2004 at 08:07:35AM +0100, Vojtech Pavlik wrote:
> USB?? This was for PS/2 mice. If it fixed your USB mouse problem, you
> were using PS/2 drivers with your USB mouse, which is wrong (although it
> can work). You need to use USB drivers.

I thought I was... all of the appropriate USB drivers are enabled, and
I haven't done anything special to load the psmouse module.  I guess
it's possible that a bootup script is loading it automagically,
tho.  I'll check into this.

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Vojtech Pavlik]

On Tue, Feb 10, 2004 at 01:48:55PM -0600, Greg Norris wrote:
> On Tue, Feb 10, 2004 at 08:07:35AM +0100, Vojtech Pavlik wrote:
> > USB?? This was for PS/2 mice. If it fixed your USB mouse problem, you
> > were using PS/2 drivers with your USB mouse, which is wrong (although it
> > can work). You need to use USB drivers.
> 
> I thought I was... all of the appropriate USB drivers are enabled, and
> I haven't done anything special to load the psmouse module.  I guess
> it's possible that a bootup script is loading it automagically,
> tho.  I'll check into this.

The most suspicious issue here is that not only psmouse gets loaded, but
that it finds a mouse attached! Note that ehci-hcd is not enough, you
also will need either uhci or ohci.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[johann lombardi]

> And here is a fix. Damn stupid mistake I made.
It solves the problem for me.
Thanks.

Johann

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Murilo Pontes]

Thanks, 
I tested by 12hours, everything is ok :)
But I want test more few days


Em Seg 09 Fev 2004 00:48, você escreveu:
> On Sat, Feb 07, 2004 at 09:11:42AM +0000, Murilo Pontes wrote:
> 
> > Problem still occurs :-(
> 
> And here is a fix. Damn stupid mistake I made.
> 

Re: [patch] Re: psmouse.c, throwing 3 bytes away

[Claudio Martins]

  Hi,

  Just to report that during many hours of desktop use and also some heavier 
use (like quake3 :-), the mouse behaved just fine without any glitches or 
error messages.

  So it seems that the problem is solved with your patch.

  Thanks for your work!

best regards

Claudio

On Monday 09 February 2004 00:48, Vojtech Pavlik wrote:
> On Sat, Feb 07, 2004 at 09:11:42AM +0000, Murilo Pontes wrote:
> > Problem still occurs :-(
>
> And here is a fix. Damn stupid mistake I made.