From: Yury Umanets <torque@ukrpost.net>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.6.6 buffer.c: bio_alloc() check
Date: Wed, 02 Jun 2004 16:28:08 +0300 [thread overview]
Message-ID: <1086182887.2898.89.camel@firefly.localdomain> (raw)
[PATCH] 2.6.6 buffer.c: adds bio_alloc() check and error handling in
fs/buffer.c.
Signed-off-by: Yury Umanets <torque@ukrpost.net>
buffer.c | 25 +++++++++++++++++++++++++
1 files changed, 25 insertions(+)
diff -rupN ./linux-2.6.6/fs/buffer.c ./linux-2.6.6-modified/fs/buffer.c
--- ./linux-2.6.6/fs/buffer.c Mon May 10 05:32:38 2004
+++ ./linux-2.6.6-modified/fs/buffer.c Wed Jun 2 15:21:47 2004
@@ -2712,6 +2712,31 @@ void submit_bh(int rw, struct buffer_hea
* submit_bio -> generic_make_request may further map this bio around
*/
bio = bio_alloc(GFP_NOIO, 1);
+ if (bio == NULL) {
+ char b[BDEVNAME_SIZE];
+
+ printk(KERN_ERR "BIO allocation failed for buffer on device "
+ "%s, logical block %Lu\n", bdevname(bh->b_bdev, b),
+ (unsigned long long)bh->b_blocknr);
+
+ /*
+ * this is needed here as some of submit_bh() callers have to
+ * wait until buffer is unlocked (that is IO is finished on it)
+ * and check its state.
+ */
+ if (rw == WRITE)
+ set_buffer_write_io_error(bh);
+ clear_buffer_uptodate(bh);
+ SetPageError(bh->b_page);
+
+ /*
+ * making all future wait_on_buffer() callers do not wait
+ * this buffer as it is errorneous.
+ */
+ if (buffer_locked(bh))
+ unlock_buffer(bh);
+ return;
+ }
bio->bi_sector = bh->b_blocknr * (bh->b_size >> 9);
bio->bi_bdev = bh->b_bdev;
--
umka
next reply other threads:[~2004-06-02 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-02 13:28 Yury Umanets [this message]
2004-06-02 13:36 ` Jens Axboe
2004-06-02 14:17 ` Yury Umanets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1086182887.2898.89.camel@firefly.localdomain \
--to=torque@ukrpost.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®