Re: [PATCH] 2.6.6 buffer.c: bio_alloc() check

[Yury Umanets <torque@ukrpost.net>]

On Wed, 2004-06-02 at 16:36, Jens Axboe wrote:
> On Wed, Jun 02 2004, Yury Umanets wrote:
> > [PATCH] 2.6.6 buffer.c: adds bio_alloc() check and error handling in
> > fs/buffer.c.
> > 
> > Signed-off-by: Yury Umanets <torque@ukrpost.net>
> > 
> >  buffer.c |   25 +++++++++++++++++++++++++
> >  1 files changed, 25 insertions(+)
> > 
> > diff -rupN ./linux-2.6.6/fs/buffer.c ./linux-2.6.6-modified/fs/buffer.c
> > --- ./linux-2.6.6/fs/buffer.c	Mon May 10 05:32:38 2004
> > +++ ./linux-2.6.6-modified/fs/buffer.c	Wed Jun  2 15:21:47 2004
> > @@ -2712,6 +2712,31 @@ void submit_bh(int rw, struct buffer_hea
> >  	 * submit_bio -> generic_make_request may further map this bio around
> >  	 */
> >  	bio = bio_alloc(GFP_NOIO, 1);
> > +	if (bio == NULL) {
> 
> This is wrong, bio_alloc() never fails if it's called with __GFP_WAIT in
> the gfp mask.
Ok, I see. Thanks.

-- 
umka