From: Jens Axboe <axboe@suse.de>
To: Yury Umanets <torque@ukrpost.net>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.6 buffer.c: bio_alloc() check
Date: Wed, 2 Jun 2004 15:36:08 +0200 [thread overview]
Message-ID: <20040602133606.GW28915@suse.de> (raw)
In-Reply-To: <1086182887.2898.89.camel@firefly.localdomain>
On Wed, Jun 02 2004, Yury Umanets wrote:
> [PATCH] 2.6.6 buffer.c: adds bio_alloc() check and error handling in
> fs/buffer.c.
>
> Signed-off-by: Yury Umanets <torque@ukrpost.net>
>
> buffer.c | 25 +++++++++++++++++++++++++
> 1 files changed, 25 insertions(+)
>
> diff -rupN ./linux-2.6.6/fs/buffer.c ./linux-2.6.6-modified/fs/buffer.c
> --- ./linux-2.6.6/fs/buffer.c Mon May 10 05:32:38 2004
> +++ ./linux-2.6.6-modified/fs/buffer.c Wed Jun 2 15:21:47 2004
> @@ -2712,6 +2712,31 @@ void submit_bh(int rw, struct buffer_hea
> * submit_bio -> generic_make_request may further map this bio around
> */
> bio = bio_alloc(GFP_NOIO, 1);
> + if (bio == NULL) {
This is wrong, bio_alloc() never fails if it's called with __GFP_WAIT in
the gfp mask.
--
Jens Axboe
next prev parent reply other threads:[~2004-06-02 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-02 13:28 Yury Umanets
2004-06-02 13:36 ` Jens Axboe [this message]
2004-06-02 14:17 ` Yury Umanets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040602133606.GW28915@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torque@ukrpost.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®