mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Kang, Luwei" <luwei.kang@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: "rkrcmar@redhat.com" <rkrcmar@redhat.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Chao Peng <chao.p.peng@linux.intel.com>
Subject: Re: [PATCH 0/9] Intel Processor Trace virtulization enabling
Date: Mon, 23 Oct 2017 16:40:13 +0200	[thread overview]
Message-ID: <109396fa-8f7c-8f24-e804-2a5b71ef0c64@redhat.com> (raw)
In-Reply-To: <82D7661F83C1A047AF7DC287873BF1E167E20AE9@SHSMSX101.ccr.corp.intel.com>

On 23/10/2017 10:01, Kang, Luwei wrote:
> 
>>> So, can we enable it in L1
>>> guest only first?  I think it is not worth to disable EPT for L1 to
>>> enable intel PT. what is your opinion?
>> Yes, we can enable it.  But since KVM sets IA32_VMX_MISC[14]=0, your patches must forbid enabling processor trace during VMX
>> operation.
>
> L1 hypervisor can't  get the capability of " TraceEn can be set in
> VMX operation (IA32_VMX_MISC[bit 14] is 0)" and set it to 0. We need
> to trap whether L1 hypervisor have enable VMXON, and forbid enable PT
> when vmxon. Is that right? Or have something else?

Correct.  I don't have the SDM at hand, so I'm not sure what happens if
you do a VMXON while TraceEn is 1.  However, that has to be handled as well.

Paolo

  reply	other threads:[~2017-10-23 14:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 12:09 Luwei Kang
2017-10-17 12:13 ` Paolo Bonzini
2017-10-18 10:18   ` Kang, Luwei
2017-10-18 10:30     ` Paolo Bonzini
2017-10-18 11:06       ` Kang, Luwei
2017-10-18 11:22         ` Paolo Bonzini
2017-10-19  5:54           ` Kang, Luwei
2017-10-19  7:14             ` Paolo Bonzini
2017-10-20  0:22               ` Kang, Luwei
2017-10-20  8:58                 ` Paolo Bonzini
2017-10-23  8:01                   ` Kang, Luwei
2017-10-23 14:40                     ` Paolo Bonzini [this message]
2017-10-18 12:53 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=109396fa-8f7c-8f24-e804-2a5b71ef0c64@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luwei.kang@intel.com \
    --cc=mingo@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome