mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Brian Masney <bmasney@redhat.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: max77843: convert to subsys_platform_driver()
Date: Sat, 7 Nov 2026 11:46:57 +0100	[thread overview]
Message-ID: <10aacc3f-9ac9-413b-9216-ee166b1c6bef@kernel.org> (raw)
In-Reply-To: <20261106-extcon-subsys-v1-1-6a781b323d6f@redhat.com>

On 07/11/2026 02:07, Brian Masney wrote:
> Reduce boilerplate code in this driver and convert it over to use
> the macro subsys_platform_driver().
> 
> Note that this driver is configured in the Kconfig to be a tristate,
> the driver doesn't have suppress_bind_attrs set, and there is no __exit
> function defined. This change will add an __exit function that
> unregisters the platform driver.
> 
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
>  drivers/extcon/extcon-max77843.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

I am 99% sure that this driver can function as module platform driver,
because it has necessary MODULE_DEVICE_TABLE() and device is not needed
for early boot.

Nevertheless, this change itself is also correct.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

      reply	other threads:[~2026-11-07 10:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07  1:07 Brian Masney
2026-11-07 10:46 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10aacc3f-9ac9-413b-9216-ee166b1c6bef@kernel.org \
    --to=krzk@kernel.org \
    --cc=bmasney@redhat.com \
    --cc=cw00.choi@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®