[PATCH] extcon: max77843: convert to subsys_platform_driver()

[PATCH] extcon: max77843: convert to subsys_platform_driver()

[Brian Masney]

Reduce boilerplate code in this driver and convert it over to use
the macro subsys_platform_driver().

Note that this driver is configured in the Kconfig to be a tristate,
the driver doesn't have suppress_bind_attrs set, and there is no __exit
function defined. This change will add an __exit function that
unregisters the platform driver.

Signed-off-by: Brian Masney <bmasney@redhat.com>
---
 drivers/extcon/extcon-max77843.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
index 2ae9f7f1a67f..6adc4cd6f94a 100644
--- a/drivers/extcon/extcon-max77843.c
+++ b/drivers/extcon/extcon-max77843.c
@@ -960,11 +960,7 @@ static struct platform_driver max77843_muic_driver = {
 	.id_table	= max77843_muic_id,
 };
 
-static int __init max77843_muic_init(void)
-{
-	return platform_driver_register(&max77843_muic_driver);
-}
-subsys_initcall(max77843_muic_init);
+subsys_platform_driver(max77843_muic_driver);
 
 MODULE_DESCRIPTION("Maxim MAX77843 Extcon driver");
 MODULE_AUTHOR("Jaewon Kim <jaewon02.kim@samsung.com>");

---
base-commit: ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b
base-tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
change-id: 20261106-extcon-subsys-24280aaba499

Best regards,
--  
Brian Masney <bmasney@redhat.com>

Re: [PATCH] extcon: max77843: convert to subsys_platform_driver()

[Krzysztof Kozlowski]

On 07/11/2026 02:07, Brian Masney wrote:
> Reduce boilerplate code in this driver and convert it over to use
> the macro subsys_platform_driver().
> 
> Note that this driver is configured in the Kconfig to be a tristate,
> the driver doesn't have suppress_bind_attrs set, and there is no __exit
> function defined. This change will add an __exit function that
> unregisters the platform driver.
> 
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
>  drivers/extcon/extcon-max77843.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

I am 99% sure that this driver can function as module platform driver,
because it has necessary MODULE_DEVICE_TABLE() and device is not needed
for early boot.

Nevertheless, this change itself is also correct.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof