* [PATCH] fix module paramater permissions in radeon_base.c
@ 2005-03-02 7:11 Greg KH
2005-03-02 7:14 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: Greg KH @ 2005-03-02 7:11 UTC (permalink / raw)
To: benh; +Cc: linux-kernel
You really don't want -2 for the file mode in sysfs. It creates:
-rwsrwsrwT 1 root root 4096 Mar 1 22:59 /sys/module/radeonfb/parameters/default_dynclk
on my box. Here's a fix against a clean 2.6.11-rc5 kernel, please
forward onward as you see fit.
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
--- 1.27/drivers/video/aty/radeon_base.c 2005-02-24 11:40:00 -08:00
+++ edited/drivers/video/aty/radeon_base.c 2005-03-01 23:09:12 -08:00
@@ -2551,7 +2551,7 @@
MODULE_DESCRIPTION("framebuffer driver for ATI Radeon chipset");
MODULE_LICENSE("GPL");
module_param(noaccel, bool, 0);
-module_param(default_dynclk, int, -2);
+module_param(default_dynclk, int, 0);
MODULE_PARM_DESC(default_dynclk, "int: -2=enable on mobility only,-1=do not change,0=off,1=on");
MODULE_PARM_DESC(noaccel, "bool: disable acceleration");
module_param(nomodeset, bool, 0);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] fix module paramater permissions in radeon_base.c
2005-03-02 7:11 [PATCH] fix module paramater permissions in radeon_base.c Greg KH
@ 2005-03-02 7:14 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2005-03-02 7:14 UTC (permalink / raw)
To: Greg KH; +Cc: Linux Kernel list
On Tue, 2005-03-01 at 23:11 -0800, Greg KH wrote:
> You really don't want -2 for the file mode in sysfs. It creates:
> -rwsrwsrwT 1 root root 4096 Mar 1 22:59 /sys/module/radeonfb/parameters/default_dynclk
>
> on my box. Here's a fix against a clean 2.6.11-rc5 kernel, please
> forward onward as you see fit.
>
>
> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
>
>
> --- 1.27/drivers/video/aty/radeon_base.c 2005-02-24 11:40:00 -08:00
> +++ edited/drivers/video/aty/radeon_base.c 2005-03-01 23:09:12 -08:00
> @@ -2551,7 +2551,7 @@
> MODULE_DESCRIPTION("framebuffer driver for ATI Radeon chipset");
> MODULE_LICENSE("GPL");
> module_param(noaccel, bool, 0);
> -module_param(default_dynclk, int, -2);
> +module_param(default_dynclk, int, 0);
> MODULE_PARM_DESC(default_dynclk, "int: -2=enable on mobility only,-1=do not change,0=off,1=on");
> MODULE_PARM_DESC(noaccel, "bool: disable acceleration");
> module_param(nomodeset, bool, 0);
Right, that is bogus, thanks.
Ben.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-02 7:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-03-02 7:11 [PATCH] fix module paramater permissions in radeon_base.c Greg KH
2005-03-02 7:14 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome