From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: linux-kernel@vger.kernel.org,
long <tlnguyen@snoqualmie.dp.intel.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Greg KH <greg@kroah.com>,
ak@muc.de, Paul Mackerras <paulus@samba.org>,
linuxppc64-dev <linuxppc64-dev@ozlabs.org>,
linux-pci@atrey.karlin.mff.cuni.cz, johnrose@us.ibm.com
Subject: Re: [PATCH 1/13]: PCI Err: pci.h header file changes
Date: Wed, 29 Jun 2005 11:43:56 +1000 [thread overview]
Message-ID: <1120009436.5133.225.camel@gaston> (raw)
In-Reply-To: <20050628235817.GA6324@austin.ibm.com>
On Tue, 2005-06-28 at 18:58 -0500, Linas Vepstas wrote:
> +
> +/* PCI bus error event callbacks */
> +struct pci_error_handlers
> +{
> + enum pci_channel_state error_state; /* current error state */
> + int (*error_detected)(struct pci_dev *dev, enum pci_channel_state error);
> + int (*mmio_enabled)(struct pci_dev *dev); /* MMIO has been reanbled, but not DMA */
> + int (*link_reset)(struct pci_dev *dev); /* PCI Express link has been reset */
> + int (*slot_reset)(struct pci_dev *dev); /* PCI slot has been reset */
> + void (*resume)(struct pci_dev *dev); /* Device driver may resume normal operations */
> +};
The state variable shouldn't be in that structure. As Greg pointed, we
should have a pointer to that structure in pci_driver, not a copy, and
the error state should be in pci_dev. (With you current code, it's per
driver which is broken anyway).
Ben.
prev parent reply other threads:[~2005-06-29 1:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 23:58 Linas Vepstas
2005-06-29 0:29 ` Greg KH
2005-06-29 3:04 ` Andi Kleen
2005-06-29 1:43 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1120009436.5133.225.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=ak@muc.de \
--cc=greg@kroah.com \
--cc=johnrose@us.ibm.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tlnguyen@snoqualmie.dp.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®