mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: linux-kernel@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	long <tlnguyen@snoqualmie.dp.intel.com>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	ak@muc.de, Paul Mackerras <paulus@samba.org>,
	linuxppc64-dev <linuxppc64-dev@ozlabs.org>,
	linux-pci@atrey.karlin.mff.cuni.cz, johnrose@us.ibm.com
Subject: Re: [PATCH 1/13]: PCI Err: pci.h header file changes
Date: Tue, 28 Jun 2005 17:29:51 -0700	[thread overview]
Message-ID: <20050629002951.GA17885@kroah.com> (raw)
In-Reply-To: <20050628235817.GA6324@austin.ibm.com>

On Tue, Jun 28, 2005 at 06:58:17PM -0500, Linas Vepstas wrote:
> @@ -673,6 +704,7 @@ struct pci_driver {
>  	int  (*enable_wake) (struct pci_dev *dev, pci_power_t state, int enable);   /* Enable wake event */
>  	void (*shutdown) (struct pci_dev *dev);
>  
> +	struct pci_error_handlers err_handler;
>  	struct device_driver	driver;
>  	struct pci_dynids dynids;
>  };

Shouldn't that be a pointer and not the whole structure?  Wouldn't that
make it easier to "reuse" error handlers?

thanks,

greg k-h

  reply	other threads:[~2005-06-29  0:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-28 23:58 Linas Vepstas
2005-06-29  0:29 ` Greg KH [this message]
2005-06-29  3:04   ` Andi Kleen
2005-06-29  1:43 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050629002951.GA17885@kroah.com \
    --to=greg@kroah.com \
    --cc=ak@muc.de \
    --cc=benh@kernel.crashing.org \
    --cc=johnrose@us.ibm.com \
    --cc=linas@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=tlnguyen@snoqualmie.dp.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®