From: Alex Lyashkov <umka@sevcity.net>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: OBATA Noboru <noboru.obata.ar@hitachi.com>,
fastboot@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [KDUMP] pending interrupts problem
Date: Thu, 27 Oct 2005 19:06:04 +0300 [thread overview]
Message-ID: <1130429164.3360.1.camel@berloga.shadowland> (raw)
In-Reply-To: <m1y84farz7.fsf@ebiederm.dsl.xmission.com>
seems to bad patch. you dereference pointer (1) before check to NULL(2).
> ---
>
> arch/i386/kernel/smp.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> applies-to: e6a6c8ed12ba1ef7fa376fa3993e3c329e9f294a
> 195ab3620ba410697ad78957226c5493d55dd2ee
> diff --git a/arch/i386/kernel/smp.c b/arch/i386/kernel/smp.c
> index 218d725..3d33125 100644
> --- a/arch/i386/kernel/smp.c
> +++ b/arch/i386/kernel/smp.c
> @@ -560,6 +560,7 @@ int smp_call_function (void (*func) (voi
> if (wait)
> while (atomic_read(&data.finished) != cpus)
> cpu_relax();
> + call_data = NULL;
> spin_unlock(&call_lock);
>
> return 0;
> @@ -609,6 +610,14 @@ fastcall void smp_call_function_interrup
> int wait = call_data->wait;
(1) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> ack_APIC_irq();
> +
> + /* Ignore spurious IPIs */
> + if (!call_data)
> + return;
(2) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
next prev parent reply other threads:[~2005-10-27 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-27 7:50 OBATA Noboru
2005-10-27 15:18 ` [Fastboot] " Eric W. Biederman
2005-11-01 9:13 ` OBATA Noboru
2005-11-01 11:34 ` Eric W. Biederman
2005-11-08 8:17 ` Vivek Goyal
2005-10-27 15:40 ` [PATCH] " Eric W. Biederman
2005-10-27 16:06 ` Alex Lyashkov [this message]
2005-10-28 0:08 ` [Fastboot] " Eric W. Biederman
2005-11-01 9:12 ` OBATA Noboru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130429164.3360.1.camel@berloga.shadowland \
--to=umka@sevcity.net \
--cc=ebiederm@xmission.com \
--cc=fastboot@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noboru.obata.ar@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome