From: OBATA Noboru <noboru.obata.ar@hitachi.com>
To: ebiederm@xmission.com
Cc: umka@sevcity.net, fastboot@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [Fastboot] Re: [PATCH] [KDUMP] pending interrupts problem
Date: Tue, 01 Nov 2005 18:12:29 +0900 (JST) [thread overview]
Message-ID: <20051101.181229.74752004.noboru.obata.ar@hitachi.com> (raw)
In-Reply-To: <m1u0f2bj18.fsf@ebiederm.dsl.xmission.com>
On Thu, 27 Oct 2005, Eric W. Biederman wrote:
>
> Alex Lyashkov <umka@sevcity.net> writes:
>
> > seems to bad patch. you dereference pointer (1) before check to NULL(2).
>
> Duh. I forgot to delete the earlier references.
> That should have been...
Thank you Eric, the patch you resent has fixed the problem,
which originally happened on vanilla 2.6.13.
But, on such an unusual case, I prefer to mark it unlikely() and
output some warning message.
> + /* Ignore spurious IPIs */
> + if (!call_data)
> + return;
if (unlikely(!call_data)) {
printk(KERN_WARNING "spurious IPI on CPU#%d, ignored\n",
smp_processor_id());
return;
}
Please take this if you like it, Eric. I have also tested this
printk-added code.
Regards,
--
OBATA Noboru (noboru.obata.ar@hitachi.com)
prev parent reply other threads:[~2005-11-01 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-27 7:50 OBATA Noboru
2005-10-27 15:18 ` [Fastboot] " Eric W. Biederman
2005-11-01 9:13 ` OBATA Noboru
2005-11-01 11:34 ` Eric W. Biederman
2005-11-08 8:17 ` Vivek Goyal
2005-10-27 15:40 ` [PATCH] " Eric W. Biederman
2005-10-27 16:06 ` Alex Lyashkov
2005-10-28 0:08 ` [Fastboot] " Eric W. Biederman
2005-11-01 9:12 ` OBATA Noboru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051101.181229.74752004.noboru.obata.ar@hitachi.com \
--to=noboru.obata.ar@hitachi.com \
--cc=ebiederm@xmission.com \
--cc=fastboot@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=umka@sevcity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®