From: ebiederm@xmission.com (Eric W. Biederman)
To: OBATA Noboru <noboru.obata.ar@hitachi.com>
Cc: fastboot@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [KDUMP] pending interrupts problem
Date: Thu, 27 Oct 2005 09:40:12 -0600 [thread overview]
Message-ID: <m1y84farz7.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20051027.165027.97297370.noboru.obata.ar@hitachi.com> (OBATA Noboru's message of "Thu, 27 Oct 2005 16:50:27 +0900 (JST)")
Being lazy does this patch fix the problem for you?
It looks like this is enough to keep the kernel going
in the face of unexpected IPIs ...
Eric
---
arch/i386/kernel/smp.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
applies-to: e6a6c8ed12ba1ef7fa376fa3993e3c329e9f294a
195ab3620ba410697ad78957226c5493d55dd2ee
diff --git a/arch/i386/kernel/smp.c b/arch/i386/kernel/smp.c
index 218d725..3d33125 100644
--- a/arch/i386/kernel/smp.c
+++ b/arch/i386/kernel/smp.c
@@ -560,6 +560,7 @@ int smp_call_function (void (*func) (voi
if (wait)
while (atomic_read(&data.finished) != cpus)
cpu_relax();
+ call_data = NULL;
spin_unlock(&call_lock);
return 0;
@@ -609,6 +610,14 @@ fastcall void smp_call_function_interrup
int wait = call_data->wait;
ack_APIC_irq();
+
+ /* Ignore spurious IPIs */
+ if (!call_data)
+ return;
+
+ func = call_data->func;
+ info = call_data->info;
+ wait = call_data->wait;
/*
* Notify initiating CPU that I've grabbed the data and am
* about to execute the function
next prev parent reply other threads:[~2005-10-27 15:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-27 7:50 OBATA Noboru
2005-10-27 15:18 ` [Fastboot] " Eric W. Biederman
2005-11-01 9:13 ` OBATA Noboru
2005-11-01 11:34 ` Eric W. Biederman
2005-11-08 8:17 ` Vivek Goyal
2005-10-27 15:40 ` Eric W. Biederman [this message]
2005-10-27 16:06 ` [PATCH] " Alex Lyashkov
2005-10-28 0:08 ` [Fastboot] " Eric W. Biederman
2005-11-01 9:12 ` OBATA Noboru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1y84farz7.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=fastboot@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noboru.obata.ar@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome