* Re: [PATCH] AGP performance fixes
[not found] <200511092002.jA9K25J8025643@hera.kernel.org>
@ 2005-11-09 23:29 ` Benjamin Herrenschmidt
2005-11-09 23:44 ` Alan Hourihane
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2005-11-09 23:29 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Dave Jones, Alan Hourihane
On Wed, 2005-11-09 at 12:02 -0800, Linux Kernel Mailing List wrote:
> tree 048db8e12c2b31ec2b88c3154da4c6a77b80028c
> parent 329f7dba5f7dc3bc9a30ad00cf373d2e83115aa1
> author Alan Hourihane <alanh@fairlite.demon.co.uk> Mon, 07 Nov 2005 15:35:34 -0800
> committer Dave Jones <davej@redhat.com> Wed, 09 Nov 2005 05:43:54 -0800
>
> [PATCH] AGP performance fixes
>
> AGP allocation/deallocation is suffering major performance issues due to
> the nature of global_flush_tlb() being called on every change_page_attr()
> call.
.../...
*** Warning: ".global_flush_tlb" [drivers/char/agp/agpgart.ko] undefined!
Am I supposed to define something new for uninorth-agp ? Is this yet another
x86-only (or worse, some x86 chipsets only concept going global ?
Ben.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] AGP performance fixes
2005-11-09 23:29 ` [PATCH] AGP performance fixes Benjamin Herrenschmidt
@ 2005-11-09 23:44 ` Alan Hourihane
2005-11-09 23:53 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Alan Hourihane @ 2005-11-09 23:44 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Linux Kernel Mailing List, Dave Jones
On Thu, 2005-11-10 at 10:29 +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2005-11-09 at 12:02 -0800, Linux Kernel Mailing List wrote:
> > tree 048db8e12c2b31ec2b88c3154da4c6a77b80028c
> > parent 329f7dba5f7dc3bc9a30ad00cf373d2e83115aa1
> > author Alan Hourihane <alanh@fairlite.demon.co.uk> Mon, 07 Nov 2005 15:35:34 -0800
> > committer Dave Jones <davej@redhat.com> Wed, 09 Nov 2005 05:43:54 -0800
> >
> > [PATCH] AGP performance fixes
> >
> > AGP allocation/deallocation is suffering major performance issues due to
> > the nature of global_flush_tlb() being called on every change_page_attr()
> > call.
>
> .../...
>
> *** Warning: ".global_flush_tlb" [drivers/char/agp/agpgart.ko] undefined!
>
> Am I supposed to define something new for uninorth-agp ? Is this yet another
> x86-only (or worse, some x86 chipsets only concept going global ?
change global_flush_tlb() to flush_agp_mappings() and you should be
fine.
Linus has a fix for this.
Alan.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] AGP performance fixes
2005-11-09 23:44 ` Alan Hourihane
@ 2005-11-09 23:53 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2005-11-09 23:53 UTC (permalink / raw)
To: Alan Hourihane; +Cc: Linux Kernel Mailing List, Dave Jones
> > Am I supposed to define something new for uninorth-agp ? Is this yet another
> > x86-only (or worse, some x86 chipsets only concept going global ?
>
> change global_flush_tlb() to flush_agp_mappings() and you should be
> fine.
>
> Linus has a fix for this.
Yup, it just showed up in git, thanks.
Ben.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-11-09 23:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200511092002.jA9K25J8025643@hera.kernel.org>
2005-11-09 23:29 ` [PATCH] AGP performance fixes Benjamin Herrenschmidt
2005-11-09 23:44 ` Alan Hourihane
2005-11-09 23:53 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®