mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <zbr@ioremap.net>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] w1: Remove unneeded header file
Date: Tue, 28 Jun 2016 16:55:28 +0300	[thread overview]
Message-ID: <113321467122128@web10m.yandex.ru> (raw)
In-Reply-To: <alpine.DEB.2.10.1606281549010.5105@hadrien>

Hi

28.06.2016, 16:50, "Julia Lawall" <julia.lawall@lip6.fr>:
>>  24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@gmail.com>:
>>  > The Coccinelle semantic patch used to make this change is as follows:
>>  > @ includesmodule @
>>  > @@
>>  >
>>  > #include <linux/module.h>
>>  >
>>  > @ depends on includesmodule @
>>  > @@
>>  >
>>  > - #include <linux/moduleparam.h>
>>  >
>>  > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
>>
>>  Looks good to me, but these @@ are pretty cryptic.
>
> There are two rules. The first checks for an include of module.h. The
> second depends on the success of the first one. It removes and include o
> moduleparam.h.

Ok, I see, it makes much more sense now :)

Thank you for clarification

      reply	other threads:[~2016-06-28 14:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24  6:18 Amitoj Kaur Chawla
2016-06-28 12:57 ` Evgeniy Polyakov
2016-06-28 13:49   ` Julia Lawall
2016-06-28 13:55     ` Evgeniy Polyakov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=113321467122128@web10m.yandex.ru \
    --to=zbr@ioremap.net \
    --cc=amitoj1606@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®