* [PATCH] w1: Remove unneeded header file
@ 2016-06-24 6:18 Amitoj Kaur Chawla
2016-06-28 12:57 ` Evgeniy Polyakov
0 siblings, 1 reply; 4+ messages in thread
From: Amitoj Kaur Chawla @ 2016-06-24 6:18 UTC (permalink / raw)
To: zbr, linux-kernel; +Cc: julia.lawall
Drop redundant include of moduleparam.h
The Coccinelle semantic patch used to make this change is as follows:
@ includesmodule @
@@
#include <linux/module.h>
@ depends on includesmodule @
@@
- #include <linux/moduleparam.h>
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/w1/w1.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 89a7847..a02361d 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -22,7 +22,6 @@
#include <linux/delay.h>
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/moduleparam.h>
#include <linux/list.h>
#include <linux/interrupt.h>
#include <linux/spinlock.h>
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] w1: Remove unneeded header file
2016-06-24 6:18 [PATCH] w1: Remove unneeded header file Amitoj Kaur Chawla
@ 2016-06-28 12:57 ` Evgeniy Polyakov
2016-06-28 13:49 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Evgeniy Polyakov @ 2016-06-28 12:57 UTC (permalink / raw)
To: Amitoj Kaur Chawla, linux-kernel; +Cc: julia.lawall
Hi
24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@gmail.com>:
> Drop redundant include of moduleparam.h
>
> The Coccinelle semantic patch used to make this change is as follows:
> @ includesmodule @
> @@
>
> #include <linux/module.h>
>
> @ depends on includesmodule @
> @@
>
> - #include <linux/moduleparam.h>
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Looks good to me, but these @@ are pretty cryptic.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] w1: Remove unneeded header file
2016-06-28 12:57 ` Evgeniy Polyakov
@ 2016-06-28 13:49 ` Julia Lawall
2016-06-28 13:55 ` Evgeniy Polyakov
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2016-06-28 13:49 UTC (permalink / raw)
To: Evgeniy Polyakov; +Cc: Amitoj Kaur Chawla, linux-kernel
On Tue, 28 Jun 2016, Evgeniy Polyakov wrote:
> Hi
>
> 24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@gmail.com>:
> > Drop redundant include of moduleparam.h
> >
> > The Coccinelle semantic patch used to make this change is as follows:
> > @ includesmodule @
> > @@
> >
> > #include <linux/module.h>
> >
> > @ depends on includesmodule @
> > @@
> >
> > - #include <linux/moduleparam.h>
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
>
> Looks good to me, but these @@ are pretty cryptic.
There are two rules. The first checks for an include of module.h. The
second depends on the success of the first one. It removes and include o
moduleparam.h.
julia
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] w1: Remove unneeded header file
2016-06-28 13:49 ` Julia Lawall
@ 2016-06-28 13:55 ` Evgeniy Polyakov
0 siblings, 0 replies; 4+ messages in thread
From: Evgeniy Polyakov @ 2016-06-28 13:55 UTC (permalink / raw)
To: Julia Lawall; +Cc: Amitoj Kaur Chawla, linux-kernel
Hi
28.06.2016, 16:50, "Julia Lawall" <julia.lawall@lip6.fr>:
>> 24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@gmail.com>:
>> > The Coccinelle semantic patch used to make this change is as follows:
>> > @ includesmodule @
>> > @@
>> >
>> > #include <linux/module.h>
>> >
>> > @ depends on includesmodule @
>> > @@
>> >
>> > - #include <linux/moduleparam.h>
>> >
>> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
>>
>> Looks good to me, but these @@ are pretty cryptic.
>
> There are two rules. The first checks for an include of module.h. The
> second depends on the success of the first one. It removes and include o
> moduleparam.h.
Ok, I see, it makes much more sense now :)
Thank you for clarification
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-28 14:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-24 6:18 [PATCH] w1: Remove unneeded header file Amitoj Kaur Chawla
2016-06-28 12:57 ` Evgeniy Polyakov
2016-06-28 13:49 ` Julia Lawall
2016-06-28 13:55 ` Evgeniy Polyakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®