From: Arjan van de Ven <arjan@infradead.org>
To: Chris Wright <chrisw@sous-sol.org>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
virtualization@lists.osdl.org,
Ian Pratt <ian.pratt@xensource.com>,
Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
Subject: Re: [RFC PATCH 33/35] Add the Xenbus sysfs and virtual device hotplug driver.
Date: Wed, 22 Mar 2006 09:53:20 +0100 [thread overview]
Message-ID: <1143017601.2955.33.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060322063807.597300000@sorel.sous-sol.org>
> +
> +extern struct semaphore xenwatch_mutex;
you know, there is this thing called "struct mutex", please use that
instead; don't add new deprecated semaphore's when using them as mutex
> +#define streq(a, b) (strcmp((a), (b)) == 0)
ehhh why?
> +EXPORT_SYMBOL(xenbus_register_frontend);
please consider _GPL
> +static void xenbus_dev_free(struct xenbus_device *xendev)
> +{
> + kfree(xendev);
> +}
why this wrapper ?
> +
> +/* Simplified asprintf. */
> +char *kasprintf(const char *fmt, ...)
> +{
> + va_list ap;
> + unsigned int len;
> + char *p, dummy[1];
> +
> + va_start(ap, fmt);
> + /* FIXME: vsnprintf has a bug, NULL should work */
> + len = vsnprintf(dummy, 0, fmt, ap);
> + va_end(ap);
> +
> + p = kmalloc(len + 1, GFP_KERNEL);
> + if (!p)
> + return NULL;
> + va_start(ap, fmt);
> + vsprintf(p, fmt, ap);
> + va_end(ap);
> + return p;
> +}
this should take a gfp mask most likely
> +
> + /* We don't refcnt properly, so set reserved on page.
> + * (this allocation is permanent) */
> + SetPageReserved(virt_to_page(page));
you may want to reconsider this given the "recent" vm changes
> + down(&xs_state.request_mutex);
please use a real mutex instead
next prev parent reply other threads:[~2006-03-22 8:53 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-22 6:30 [RFC PATCH 00/35] Xen i386 paravirtualization support Chris Wright
2006-03-22 6:30 ` [RFC PATCH 01/35] Add XEN config options and disable unsupported config options Chris Wright
2006-03-22 6:30 ` [RFC PATCH 02/35] Makefile support to build Xen subarch Chris Wright
2006-03-22 6:30 ` [RFC PATCH 03/35] Add Xen interface header files Chris Wright
2006-03-22 6:30 ` [RFC PATCH 04/35] Hypervisor " Chris Wright
2006-03-22 8:28 ` Arjan van de Ven
2006-03-22 9:31 ` Keir Fraser
2006-03-22 9:46 ` Arjan van de Ven
2006-03-22 11:32 ` David Schwartz
2006-03-22 14:29 ` Keir Fraser
2006-03-22 6:30 ` [RFC PATCH 05/35] Add sync bitops Chris Wright
2006-03-22 6:30 ` [RFC PATCH 06/35] Add vmlinuz build target Chris Wright
2006-03-22 6:30 ` [RFC PATCH 07/35] Make LOAD_OFFSET defined by subarch Chris Wright
2006-03-22 22:57 ` Dan Hecht
2006-03-27 8:18 ` Gerd Hoffmann
2006-03-22 6:30 ` [RFC PATCH 08/35] Add Xen-specific memory management definitions Chris Wright
2006-03-22 6:30 ` [RFC PATCH 09/35] Change __FIXADDR_TOP to leave room for the hypervisor Chris Wright
2006-03-22 17:27 ` Anthony Liguori
2006-03-22 17:32 ` Chris Wright
2006-03-22 6:30 ` [RFC PATCH 10/35] Add a new head.S start-of-day file for booting on Xen Chris Wright
2006-03-22 13:43 ` Andi Kleen
2006-03-22 18:58 ` Chris Wright
2006-03-22 18:45 ` Andi Kleen
2006-03-22 19:26 ` Chris Wright
2006-03-22 6:30 ` [RFC PATCH 11/35] Add support for Xen to entry.S Chris Wright
2006-03-22 13:55 ` Andi Kleen
2006-03-22 17:24 ` [Xen-devel] " Zachary Amsden
2006-03-22 6:30 ` [RFC PATCH 12/35] Add start-of-day setup hooks to subarch Chris Wright
2006-03-22 6:30 ` [RFC PATCH 13/35] Support loading an initrd when running on Xen Chris Wright
2006-03-22 14:22 ` Andi Kleen
2006-03-22 19:20 ` Chris Wright
2006-03-22 6:30 ` [RFC PATCH 14/35] subarch modify CPU capabilities Chris Wright
2006-03-22 8:35 ` [Xen-devel] " Zachary Amsden
2006-03-22 9:33 ` Keir Fraser
2006-03-22 19:29 ` Chris Wright
2006-03-22 6:30 ` [RFC PATCH 15/35] subarch support for controlling interrupt delivery Chris Wright
2006-03-22 6:30 ` [RFC PATCH 16/35] subarch support for interrupt and exception gates Chris Wright
2006-03-22 13:45 ` Andi Kleen
2006-03-22 20:54 ` Chris Wright
2006-03-22 6:30 ` [RFC PATCH 17/35] Segment register changes for Xen Chris Wright
2006-03-22 14:24 ` Andi Kleen
2006-03-22 19:33 ` Chris Wright
2006-03-23 0:16 ` Zachary Amsden
2006-03-22 6:30 ` [RFC PATCH 18/35] Support gdt/idt/ldt handling on Xen Chris Wright
2006-03-22 14:30 ` Andi Kleen
2006-03-22 17:51 ` [Xen-devel] " Zachary Amsden
2006-03-22 17:36 ` Andi Kleen
2006-03-22 6:30 ` [RFC PATCH 19/35] subarch support for control register accesses Chris Wright
2006-03-22 8:55 ` Zachary Amsden
2006-03-22 21:45 ` Chris Wright
2006-03-22 6:31 ` [RFC PATCH 20/35] subarch stack pointer update Chris Wright
2006-03-22 6:31 ` [RFC PATCH 21/35] subarch TLB support Chris Wright
2006-03-22 6:31 ` [RFC PATCH 22/35] subarch suport for idle loop (NO_IDLE_HZ for Xen) Chris Wright
2006-03-22 6:31 ` [RFC PATCH 23/35] Add support for Xen event channels Chris Wright
2006-03-22 8:36 ` Arjan van de Ven
2006-03-22 11:30 ` Keir Fraser
2006-03-22 14:07 ` Andi Kleen
2006-03-22 6:31 ` [RFC PATCH 24/35] subarch support for mask value for irq nubmers Chris Wright
2006-03-22 6:31 ` [RFC PATCH 25/35] Add Xen time abstractions Chris Wright
2006-03-22 8:38 ` Arjan van de Ven
2006-03-22 19:37 ` Chris Wright
2006-03-22 22:26 ` [Xen-devel] " Dan Hecht
2006-03-23 3:23 ` [Xen-devel] " Eli Collins
2006-03-23 6:47 ` Chris Wright
2006-03-22 6:31 ` [RFC PATCH 26/35] Add Xen subarch reboot support Chris Wright
2006-03-22 8:40 ` Arjan van de Ven
2006-03-22 10:22 ` Keir Fraser
2006-03-22 10:39 ` Arjan van de Ven
2006-03-22 10:52 ` Keir Fraser
2006-03-22 14:21 ` Andi Kleen
2006-03-22 20:59 ` Pavel Machek
2006-03-22 6:31 ` [RFC PATCH 27/35] Add nosegneg capability to the vsyscall page notes Chris Wright
2006-03-22 6:31 ` [RFC PATCH 28/35] add support for Xen feature queries Chris Wright
2006-03-22 8:42 ` Arjan van de Ven
2006-03-22 6:31 ` [RFC PATCH 29/35] Add the Xen virtual console driver Chris Wright
2006-03-22 8:43 ` Arjan van de Ven
2006-03-22 9:29 ` Keir Fraser
2006-03-22 14:17 ` Andi Kleen
2006-03-22 16:00 ` Anthony Liguori
2006-03-22 16:07 ` Keir Fraser
2006-03-22 16:14 ` Anthony Liguori
2006-03-22 6:31 ` [RFC PATCH 30/35] Add generic_page_range() function Chris Wright
2006-03-22 8:51 ` Zachary Amsden
2006-03-22 9:27 ` [Xen-devel] " Keir Fraser
2006-03-22 11:21 ` Nick Piggin
2006-03-22 14:33 ` Keir Fraser
2006-03-22 15:35 ` Keir Fraser
2006-03-23 0:15 ` Nick Piggin
2006-03-23 0:26 ` Nick Piggin
2006-03-22 6:31 ` [RFC PATCH 31/35] Add Xen grant table support Chris Wright
2006-03-22 8:45 ` Arjan van de Ven
2006-03-22 18:38 ` Chris Wright
2006-03-22 6:31 ` [RFC PATCH 32/35] Add Xen driver utility functions Chris Wright
2006-03-22 14:12 ` Andi Kleen
2006-03-22 6:31 ` [RFC PATCH 33/35] Add the Xenbus sysfs and virtual device hotplug driver Chris Wright
2006-03-22 8:53 ` Arjan van de Ven [this message]
2006-03-22 11:14 ` Keir Fraser
2006-03-22 6:31 ` [RFC PATCH 34/35] Add the Xen virtual network device driver Chris Wright
2006-03-22 8:59 ` Arjan van de Ven
2006-03-22 15:29 ` James Morris
2006-03-22 17:17 ` Stephen Hemminger
2006-03-22 6:31 ` [RFC PATCH 35/35] Add Xen virtual block " Chris Wright
2006-03-22 16:39 ` Anthony Liguori
2006-03-22 16:54 ` Christoph Hellwig
2006-03-27 8:42 ` Gerd Hoffmann
2006-03-22 17:15 ` [RFC PATCH 00/35] Xen i386 paravirtualization support Anthony Liguori
2006-03-22 17:27 ` Chris Wright
2006-03-22 17:50 ` Anthony Liguori
2006-05-09 8:49 Chris Wright
2006-05-09 7:00 ` [RFC PATCH 33/35] Add the Xenbus sysfs and virtual device hotplug driver Chris Wright
2006-05-09 16:06 ` Alexey Dobriyan
2006-05-09 16:28 ` Andi Kleen
2006-05-09 19:40 ` Greg KH
2006-05-09 21:53 ` Chris Wright
2006-05-09 22:01 ` Greg KH
2006-05-09 22:50 ` Chris Wright
2006-05-09 23:43 ` Anthony Liguori
2006-05-09 19:49 ` Greg KH
2006-05-09 19:58 ` Chris Wright
2006-05-13 12:28 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1143017601.2955.33.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=Christian.Limpach@cl.cam.ac.uk \
--cc=chrisw@sous-sol.org \
--cc=ian.pratt@xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®